Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Standardize fake URL used for testing #379

Open
vyasr opened this issue Feb 23, 2023 · 0 comments
Open

[FEA] Standardize fake URL used for testing #379

vyasr opened this issue Feb 23, 2023 · 0 comments
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@vyasr
Copy link
Contributor

vyasr commented Feb 23, 2023

Is your feature request related to a problem? Please describe.
Currently a number of the tests use a fake URL. That URL is hardcoded in a number of places and is written out within bracket expressions where it cannot be directly substituted with a variable.

Describe the solution you'd like
It would be nice to find a way to save this URL in one place to minimize the possibility of typos causing test failures later. See #377 (comment) for more discussion.
@vyasr vyasr added feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 23, 2023
@vyasr vyasr mentioned this issue Feb 23, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vyasr