Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] rapids_cmake_write_version_file() extras #687

Open
Jacobfaib opened this issue Aug 29, 2024 · 0 comments
Open

[FEA] rapids_cmake_write_version_file() extras #687

Jacobfaib opened this issue Aug 29, 2024 · 0 comments
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@Jacobfaib
Copy link
Contributor

rapids_cmake_write_version_file() currently only results in

#define PROJECT_VERSION_MAJOR
#define PROJECT_VERSION_MINOR
#define PROJECT_VERSION_PATCH

but there are a few other "version" related utility macros that it could generate while we are at it:

  1. PROJECT_VERSION (literally just PROJECT_VERSION_MAJOR.PROJECT_VERSION_MINOR.PROJECT_VERSION_PATCH, or some other scheme).
  2. PROJECT_VERSION_GT/LT/EQ: e.g. PROJECT_VERSION_GT(10, 5, 0) evaluates true if current version is strictly greater than 10.5.0, false otherwise.
@Jacobfaib Jacobfaib added ? - Needs Triage Need team to review and classify feature request New feature or request labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jacobfaib