-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config
ignores peerDependencies
and instead reads devDependencies
#2419
Comments
@thymikee: Let me know what you think. I can submit a fix once we agree on a solution. |
Ideally we should rely on |
There hasn't been any activity on this issue in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Description
config
ignorespeerDependencies
and instead readsdevDependencies
:cli/packages/cli-config/src/findDependencies.ts
Lines 18 to 21 in 33646ef
This leads to errors in
react-native-windows
autolinking (and possibly in other scenarios) where dependencies are only declared underpeerDependencies
and notdevDependencies
, for instance in@react-native-webapis/web-storage
we have the following:In this case,
config
outputs:If I add
react-native-windows
todevDependencies
,config
outputs:In my opinion, the correct fix should be to replace
devDependencies
withpeerDependencies
, but I don't know if this will break current scenarios so we should probably keep it as is and just addpeerDependencies
to the list infindDependencies.ts
.Reproducible Demo
In any project, you can run the following:
The text was updated successfully, but these errors were encountered: