Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: In v8, DIM support broke for default implementations of inherited methods #1951

Open
mkane91301 opened this issue Jan 30, 2025 · 0 comments
Labels

Comments

@mkane91301
Copy link

Describe the bug 🐞

In v7, this worked:

public interface IFoo
{
    int Bar();
}

internal interface IInternalFoo : IFoo
{
    int IFoo.Bar() => InternalBar() + 1;

    [Get("/bar")]
    internal int InternalBar();
}

In v8, it complains that IFoo.Bar doesn't have a Refit attribute or the path isn't a string.

Step to reproduce

  1. Copy the code.
  2. Compile it.
  3. See the warnings.
  4. Try to run it in a unit test.
  5. See the errors.

Reproduction repository

https://github.com/reactiveui/refit

Expected behavior

The behavior should not have changed between v7 and v8.

Screenshots 🖼️

No response

IDE

No response

Operating system

No response

Version

No response

Device

No response

Refit Version

8

Additional information ℹ️

No response

@mkane91301 mkane91301 added the bug label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant