-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Children with aria role="tab" cause parent tabs to reset #345
Comments
We were having the exact same issue. Our accordion component when used within tabs would break as this package assumed all A surprisingly small fix we were able to make was to add a react-tabs/src/components/UncontrolledTabs.js Lines 318 to 339 in a37ca85
|
this will not reset the tabs |
Simple Reproduction here https://codesandbox.io/s/crimson-sun-wrp0w
I was trying to use rc-collapse which is an accessible collapse component, when you have the accordion mode enabled then it correctly sets the components to have the aria-roles to tablist/tab/tabpanel unfortunately this causes the react-tabs component to think that clicks to open the accordion are a trigger for the tabs.
The text was updated successfully, but these errors were encountered: