Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip legacy TLS 1.0 tests if disabled by system #281

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

clue
Copy link
Member

@clue clue commented Jan 5, 2022

Skip legacy TLS 1.0 tests if disabled by system. For example, this affects Fedora 36 installations which prohibit legacy TLS 1.0 connections by default. By today's standards, TLS 1.0 would be considered insecure, so it makes sense this is prohibited by default even if explicitly requested like in our test suite. Accordingly, this changeset only affects the test suite and has no effect on runtime.

For PHP, this can be reproduced (prior to applying this patch) by running the test suite in a default Fedora 36 installation like this:

$ docker run -it --rm -v `pwd`:/data --workdir=/data fedora:36 bash
# dnf install php-cli php-dom php-mbstring
# vendor/bin/phpunit

Resolves / closes #275
Builds on top of #229

@clue clue added this to the v1.11.0 milestone Jan 5, 2022
@clue clue requested a review from WyriHaximus January 6, 2022 14:50
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WyriHaximus WyriHaximus merged commit 85a920a into reactphp:master Jan 10, 2022
@clue clue deleted the tls1.0 branch January 10, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed tests with OpenSSL 3
3 participants