New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should kafka message pump be outside server span? #599

Open

spladug opened this issue Jun 21, 2021 · 0 comments

Labels

bug

Contributor

spladug commented Jun 21, 2021

https://github.com/reddit/baseplate.py/blob/develop/baseplate/frameworks/queue_consumer/kafka.py#L77

This sleep is inside a server span so it's subject to timeouts. That doesn't seem right since it's kinda on the outside of the event loop.

spladug added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment