Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Becomes a standalone extension that works with deno extensions #5

Open
janckerchen opened this issue Nov 15, 2024 · 3 comments
Open
Assignees
Labels
debate debate / discussion

Comments

@janckerchen
Copy link

Standalone extensions are probably better than the fork approach.

I've looked at the changes, and the main ones are the addition of Session, Deno spawn, serializer, which could have been standalone extensions to work with vscode-deno. I don't really understand why they are integrated.

vscode-deno already provides lsp, so I don't understand why it needs additional support.

@redking00 redking00 added the debate debate / discussion label Nov 15, 2024
@redking00
Copy link
Owner

redking00 commented Nov 15, 2024

Take a look on this issue for some background on the lsp problem.

Currently the extension is a fork due to the lsp issue.
I would love to see the official lsp updated in its own repo (deno) and the controller and serializer in the official extension repository, but if that were not the case, I would publish the controller and serializer as add-on extensions.

@redking00
Copy link
Owner

redking00 commented Nov 20, 2024

@janckerchen, Added support for running typescript ipynb files on the controller.

@janckerchen
Copy link
Author

Wow, I can get rid of all the Jupyter plugins and Python environments, and I feel completely refreshed.

image

@redking00 redking00 self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debate debate / discussion
Projects
None yet
Development

No branches or pull requests

2 participants