-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: Cannot read properties of undefined (reading 'inTable') in v4.0.0 #57
Comments
Duplicate of remarkjs/react-markdown#763 |
This comment has been minimized.
This comment has been minimized.
Hi! Thanks for taking the time to contribute! Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related. Thanks, |
The updates are making their way through several hundred packages, for now pin the previous major until the new |
@ChristianMurphy I'm a bit confused, how is this a duplicate of a typescript related issue? This is not a typescript error, this is a runtime error. |
A major version release is rolling out across all: |
Is this issue fixed yet? |
@AshuGuptaGamer there is nothing to "fix" it isn't a bug. The major releases are still rolling out across the |
- remark-gfm seems like [this issue has been resolved](remarkjs/remark-gfm#57)
* upgrade dependencies * wip add contentlayer * wip update links and head tags * get next-themes working kinda * create-react-app for next 14 * idk, remove purgecss? * fix some invalid HTML * get projects kinda working * wip add blog to app * kinda get projects working * get blog working * get projects working * migrate contact page * migrate 404 * use built-in to transpile modules see https://nextjs.org/docs/app/api-reference/next-config-js/transpilePackages * add tailwind back * misc cleanup * fix tailwind content dirs * add blog post layout * rm more layouts * fix projects index * sort projects by date desc * tweak project card borders * pull out project item into its own file since I'll maybe use client at some point * add music page * kill last layout * oops add missing import * add more metadata * fix date vs. publishedAt * fix eslint errors * fixed some MDX components * use contentlayer for music * wip add test page * use remark-gfm@3 since v4 is still getting rolled out see remarkjs/remark-gfm#57 * update iframe * rm gray-matter * upgrade eslint * rm @types/react-syntax-highlighter because it was causing issues see react-syntax-highlighter/react-syntax-highlighter#539 * fix Google Analytics * fix some loudness wars typescript issues * first successful `yarn build` 🎉 * fix some stuff around slugs * i uhhhh alright I guess I'm escaping urls in my paths now * rm dummy next-14 dir * get cypress in a runnable state * kill react-spring / reach * daaaaang framer motion is cool * add social links to mobile nav * use new next ESLint plugin * clean up dependencies * run eslint * fix some blog metadata * fix more metadata * use FancyH1 for 404 * fix blog post title heading * add leading-8 to project and blog post pages * defer to tailwind typography over custom styles * fix tailwind content path * fix some more classnames and typography * fix project card image heights * minor tweaks to conform w/ Tailwind typography * change url * use [role="dialog"] instead of custom CSS selector * rm deprecated property * tell cypress it's ok to continue to NEXT_NOT_FOUND errors * fix music headings tests * rm double underline from links * make github percy quiet * add sharp * use custom h1 for project page * lint * rm dead code * fix og:image assertion * add favicon and apple-icon * rm unused permalink * fix project image link in head * add twitter to metadata * fix issue where I was only taking a screenshot of every other project * make dividing line in mobile nav dark theme aware * wait before taking screenshot of mobile nav * update browserslist * mv blog heading into page, not layout
Still getting this error after updating to:
|
You can make a PR to Run |
|
Thanks for much for reviewing. Here's what I got after running
Is where we trigger the problem. If I remove |
This looks like a screenshot from the VSCode remark extension. I’ve been holding back updating this until |
Thanks all. This seems to resolve the issue by forcibly overriding in
|
- mdx's `remark-gfm` plugin does not work since its latest major version remarkjs/remark-gfm#57
It is still not fixed, right? And the best approach is syntax-tree/mdast-util-from-markdown#34 (comment)
Is it correct? |
It is fixed by now. See https://github.com/remarkjs/react-markdown/releases/tag/9.0.0. The comment you linked precedes that release. |
@remcohaszing Thank you for quick response. I got this error with "remark-gfm": "4.0.0", and recommendation here contentlayerdev/contentlayer#611 (comment) to check this issue. Or do we mean different issues?
package.json
|
I suggest you run You can try to fix it by removing |
Thank you for your patience and help. I added It didn't help. But I add '"mdast-util-frontmatter": "2.0.1"' in addition:
Now it works. Just for google, if other devs will have the same compatibility issue
|
You should never use |
Should this be reopened? |
This is not a bug. If you’re seeing this, it means some of your dependencies are outdated, but not all. |
Affected packages and versions
4.0.0
Link to runnable example
https://github.com/arechsteiner/gfm-bug/blob/main/src/App.tsx#L12
Steps to reproduce
Attempt to render
With
Expected behavior
Previously this was no issue.
Actual behavior
TypeError: Cannot read properties of undefined (reading 'inTable')
Runtime
No response
Package manager
yarn 1
OS
macOS
Build and bundle tools
Vite
The text was updated successfully, but these errors were encountered: