Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use no-code VSCode integration #121

Closed
4 tasks done
remcohaszing opened this issue Aug 15, 2022 · 6 comments
Closed
4 tasks done

Use no-code VSCode integration #121

remcohaszing opened this issue Aug 15, 2022 · 6 comments
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on

Comments

@remcohaszing
Copy link
Member

Initial checklist

Problem

Currently we need a bunch of boilerplate code to create a client for integrating remark-language-server into this extension. This adds ~350kB of minified JavaScript.

Solution

I created feature request microsoft/vscode#158076 upstream. If it gets accepted (needs 20 👍 votes) and implemented, we can remove the client code entirely.

Alternatives

If the upstream doesn’t get accepted, we should just close this issue.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 15, 2022
@wooorm
Copy link
Member

wooorm commented Aug 15, 2022

@remarkjs/contributors The call to action here is: Please upvote this issue microsoft/vscode#158076 (assuming you think it is a good idea 😉). Thanks!

@wooorm
Copy link
Member

wooorm commented Aug 23, 2022

@remarkjs/contributors Friendly ping 🛎. Only 4 👍 are missing!

@JounQin
Copy link
Member

JounQin commented Aug 23, 2022

I just asked my colleagues for help.

@wooorm
Copy link
Member

wooorm commented Oct 27, 2023

Should we keep this open? It’s been more than a year. Might be never.

@remcohaszing
Copy link
Member Author

My plan was basically:

  • Wait for remark-lint releases
  • Release remark-language-server
  • Release vscode-remark
  • Close this issue as We’ll see whenever this gets implemented.

So yeah, I’ll close it now.

@remcohaszing remcohaszing closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2023
@github-actions

This comment has been minimized.

@remcohaszing remcohaszing added the 🙅 no/wontfix This is not (enough of) an issue for this project label Oct 27, 2023
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

3 participants