You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The plugins are discovered by querying files in directories. This behavior is different depending on the underlying filesystem, means:
Window/NFTS: alphanumerical
Linux/ext: "inode" order
This leads to the situation that the loading is different when you locally test with Windows and on the pipeline the tests are running on a linux agent.
This is per se a bit inconsistent, but for us it is a problem as we have a plugin which is overwriting the tracing. We enforce by the plugin-name that our plugin is loaded last, which now only works with NTFS.
The "fix" for this would be quite easy:
internal sealed class RuntimePluginLocator : IRuntimePluginLocator
{
....
public IReadOnlyList<string> GetAllRuntimePlugins()
{
...
return _runtimePluginLocationMerger.Merge(allRuntimePlugins).OrderBy(plugin => plugin).ToList(); // Add ordering of the returned list
}
}
This would always give a sorted list back and the loading is independent of the behavior of the filesystem, which is a small change but would help us a lot.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
The plugins are discovered by querying files in directories. This behavior is different depending on the underlying filesystem, means:
Window/NFTS: alphanumerical
Linux/ext: "inode" order
This leads to the situation that the loading is different when you locally test with Windows and on the pipeline the tests are running on a linux agent.
This is per se a bit inconsistent, but for us it is a problem as we have a plugin which is overwriting the tracing. We enforce by the plugin-name that our plugin is loaded last, which now only works with NTFS.
The "fix" for this would be quite easy:
This would always give a sorted list back and the loading is independent of the behavior of the filesystem, which is a small change but would help us a lot.
Beta Was this translation helpful? Give feedback.
All reactions