Contributor Roles and Teams

[gasparnagy]

I have setup the following teams for the Reqnroll GitHub organization:

• contributors
  • the members have write access to the main repositories and can create branches there to make PRs easier (without needing to fork)
  • the "main" branch is protected (*), so they can only push to main through PRs
  • everyone with an approved PR with code change within a year will be part of the team (currently maintained manually)
• core-team
  • permissions of "contributor" team, plus
  • can push to "main" branch and approve/merge PRs
  • members will be asked to give feedback on every strategic decisions
  • members can be notified using the @core-team mention form in discussions & issues
  • people with activities in bigger or multiple areas / discussions will be part of the team

Members of any org team required to have two-factor GitHub authentication.

(*) setting up branch protection for main is still in progress

Any feedback on this is appreciated.

[304NotModified]

Some feedback :)

On #479 (comment):

• The contributors team link won't work unless your in a/the team - that's a bit confusing
• The invitation was a bit hard to find, but we can't do much about that I guess

On above:

the members have write access to the main repositories and can create branches there to make PRs easier (without needing to fork)

I think this isn't a good idea. Nowadays it's really easy to keep your fork up-to-date (there is a nice sync button). As with open source, contributors arrive and leave, and now there is the problem we get stale branches and those are hard to delete (when?). See also https://github.com/reqnroll/Reqnroll/branches/stale and https://github.com/reqnroll/Reqnroll.VisualStudio/branches/stale

IMO this won't make it easier, but less easy as I also created a branch on the origin while otherwise the web UI makes it in my fork.

PS: I'm happy that I could edit/update Github issues and run the pipelines. That really helps in keeping things up-to-date and completing the PRs for review.

can push to "main" branch and approve/merge PRs

I never like to push to main without PRs. It's tricky. I propose that all changes needs a PR - maybe that's already the case, not sure :)