nodeselector_test.go-948d14cbd1c8866ce77ff586608f461af0dc4bad04b5f86df2695834e3264d95

// PUBLISH-CODE
/*
Copyright 2020 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

// This code is taken from github.com/kubernetes/component-helpers/scheduling/corev1
// and modified.

package selector

import (
	"testing"

	"github.com/stretchr/testify/require"
	core "go.tectonic.network/lib/k8s/imp/api/core/v1"
	metav1 "go.tectonic.network/lib/k8s/meta/v1"
)

// from nodeaffinity/nodeaffinity_test.go
func TestNodeSelectorMatch(t *testing.T) {
	tests := []struct {
		name         string
		nodeSelector core.NodeSelector
		node         *core.Node
		wantErr      bool
		wantMatch    bool
	}{
		{
			name:      "nil node",
			wantMatch: false,
		},
		{
			name: "invalid field selector and label selector",
			nodeSelector: core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
				{
					MatchFields: []core.NodeSelectorRequirement{{
						Key:      "metadata.name",
						Operator: core.NodeSelectorOpIn,
						Values:   []string{"host_1", "host_2"},
					}},
				},
				{
					MatchExpressions: []core.NodeSelectorRequirement{{
						Key:      "label_1",
						Operator: core.NodeSelectorOpIn,
						Values:   []string{"label_1_val"},
					}},
					MatchFields: []core.NodeSelectorRequirement{{
						Key:      "metadata.name",
						Operator: core.NodeSelectorOpIn,
						Values:   []string{"host_1"},
					}},
				},
				{
					MatchExpressions: []core.NodeSelectorRequirement{{
						Key:      "invalid key",
						Operator: core.NodeSelectorOpIn,
						Values:   []string{"label_value"},
					}},
				},
			}},
		},
		{
			name: "node matches field selector, but not labels",
			nodeSelector: core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
				{
					MatchExpressions: []core.NodeSelectorRequirement{{
						Key:      "label_1",
						Operator: core.NodeSelectorOpIn,
						Values:   []string{"label_1_val"},
					}},
					MatchFields: []core.NodeSelectorRequirement{{
						Key:      "metadata.name",
						Operator: core.NodeSelectorOpIn,
						Values:   []string{"host_1"},
					}},
				},
			}},
			node: &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "host_1"}},
		},
		{
			name: "node matches field selector and label selector",
			nodeSelector: core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
				{
					MatchExpressions: []core.NodeSelectorRequirement{{
						Key:      "label_1",
						Operator: core.NodeSelectorOpIn,
						Values:   []string{"label_1_val"},
					}},
					MatchFields: []core.NodeSelectorRequirement{{
						Key:      "metadata.name",
						Operator: core.NodeSelectorOpIn,
						Values:   []string{"host_1"},
					}},
				},
			}},
			node:      &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "host_1", Labels: map[string]string{"label_1": "label_1_val"}}},
			wantMatch: true,
		},
		{
			name: "second term matches",
			nodeSelector: core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
				{
					MatchExpressions: []core.NodeSelectorRequirement{{
						Key:      "label_1",
						Operator: core.NodeSelectorOpIn,
						Values:   []string{"label_1_val"},
					}},
				},
				{
					MatchFields: []core.NodeSelectorRequirement{{
						Key:      "metadata.name",
						Operator: core.NodeSelectorOpIn,
						Values:   []string{"host_1"},
					}},
				},
			}},
			node:      &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "host_1"}},
			wantMatch: true,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			match, err := nodeSelectorsMatchesNodeAffinity(tt.nodeSelector, tt.node)
			require.NoError(t, err)
			if match != tt.wantMatch {
				t.Errorf("NodeSelector.Match returned %t, want %t", match, tt.wantMatch)
			}
		})
	}
}

// from nodeaffinity/nodeaffinity_test.go
func TestPodMatchesNodeSelectorAndAffinityTerms(t *testing.T) {
	tests := []struct {
		name     string
		pod      *core.Pod
		labels   map[string]string
		nodeName string
		want     bool
	}{
		{
			name: "no selector",
			pod:  &core.Pod{},
			want: true,
		},
		{
			name: "missing labels",
			pod: &core.Pod{
				Spec: core.PodSpec{
					NodeSelector: map[string]string{
						"foo": "bar",
					},
				},
			},
			want: false,
		},
		{
			name: "same labels",
			pod: &core.Pod{
				Spec: core.PodSpec{
					NodeSelector: map[string]string{
						"foo": "bar",
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
			},
			want: true,
		},
		{
			name: "node labels are superset",
			pod: &core.Pod{
				Spec: core.PodSpec{
					NodeSelector: map[string]string{
						"foo": "bar",
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
				"baz": "blah",
			},
			want: true,
		},
		{
			name: "node labels are subset",
			pod: &core.Pod{
				Spec: core.PodSpec{
					NodeSelector: map[string]string{
						"foo": "bar",
						"baz": "blah",
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
			},
			want: false,
		},
		{
			name: "Pod with matchExpressions using In operator that matches the existing node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "foo",
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"bar", "value2"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
			},
			want: true,
		},
		{
			name: "Pod with matchExpressions using Gt operator that matches the existing node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "kernel-version",
												Operator: core.NodeSelectorOpGt,
												Values:   []string{"0204"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				// We use two digit to denote major version and two digit for minor version.
				"kernel-version": "0206",
			},
			want: true,
		},
		{
			name: "Pod with matchExpressions using NotIn operator that matches the existing node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "mem-type",
												Operator: core.NodeSelectorOpNotIn,
												Values:   []string{"DDR", "DDR2"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"mem-type": "DDR3",
			},
			want: true,
		},
		{
			name: "Pod with matchExpressions using Exists operator that matches the existing node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "GPU",
												Operator: core.NodeSelectorOpExists,
											},
										},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"GPU": "NVIDIA-GRID-K1",
			},
			want: true,
		},
		{
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "foo",
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"value1", "value2"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
			},
			want: false,
			name: "Pod with affinity that don't match node's labels won't schedule onto the node",
		},
		{
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: nil,
							},
						},
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
			},
			want: false,
			name: "Pod with a nil []NodeSelectorTerm in affinity, can't match the node's labels and won't schedule onto the node",
		},
		{
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
			},
			want: false,
			name: "Pod with an empty []NodeSelectorTerm in affinity, can't match the node's labels and won't schedule onto the node",
		},
		{
			name: "Pod with empty MatchExpressions is not a valid value will match no objects and won't schedule onto the node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
			},
			want: false,
		},
		{
			name: "Pod with no Affinity will schedule onto a node",
			pod:  &core.Pod{},
			labels: map[string]string{
				"foo": "bar",
			},
			want: true,
		},
		{
			name: "Pod with Affinity but nil NodeSelector will schedule onto a node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: nil,
						},
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
			},
			want: true,
		},
		{
			name: "Pod with multiple matchExpressions ANDed that matches the existing node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "GPU",
												Operator: core.NodeSelectorOpExists,
											}, {
												Key:      "GPU",
												Operator: core.NodeSelectorOpNotIn,
												Values:   []string{"AMD", "INTER"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"GPU": "NVIDIA-GRID-K1",
			},
			want: true,
		},
		{
			name: "Pod with multiple matchExpressions ANDed that doesn't match the existing node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "GPU",
												Operator: core.NodeSelectorOpExists,
											}, {
												Key:      "GPU",
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"AMD", "INTER"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"GPU": "NVIDIA-GRID-K1",
			},
			want: false,
		},
		{
			name: "Pod with multiple NodeSelectorTerms ORed in affinity, matches the node's labels and will schedule onto the node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "foo",
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"bar", "value2"},
											},
										},
									},
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "diffkey",
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"wrong", "value2"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
			},
			want: true,
		},
		{
			name: "Pod with an Affinity and a PodSpec.NodeSelector(the old thing that we are deprecating) " +
				"both are satisfied, will schedule onto the node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					NodeSelector: map[string]string{
						"foo": "bar",
					},
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "foo",
												Operator: core.NodeSelectorOpExists,
											},
										},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"foo": "bar",
			},
			want: true,
		},
		{
			name: "Pod with an Affinity matches node's labels but the PodSpec.NodeSelector(the old thing that we are deprecating) " +
				"is not satisfied, won't schedule onto the node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					NodeSelector: map[string]string{
						"foo": "bar",
					},
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "foo",
												Operator: core.NodeSelectorOpExists,
											},
										},
									},
								},
							},
						},
					},
				},
			},
			labels: map[string]string{
				"foo": "barrrrrr",
			},
			want: false,
		},
		{
			name: "Pod with matchFields using In operator that matches the existing node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchFields: []core.NodeSelectorRequirement{
											{
												Key:      metav1.ObjectNameField,
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"node_1"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			nodeName: "node_1",
			want:     true,
		},
		{
			name: "Pod with matchFields using In operator that does not match the existing node",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchFields: []core.NodeSelectorRequirement{
											{
												Key:      metav1.ObjectNameField,
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"node_1"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			nodeName: "node_2",
			want:     false,
		},
		{
			name: "Pod with two terms: matchFields does not match, but matchExpressions matches",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchFields: []core.NodeSelectorRequirement{
											{
												Key:      metav1.ObjectNameField,
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"node_1"},
											},
										},
									},
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "foo",
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"bar"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			nodeName: "node_2",
			labels:   map[string]string{"foo": "bar"},
			want:     true,
		},
		{
			name: "Pod with one term: matchFields does not match, but matchExpressions matches",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchFields: []core.NodeSelectorRequirement{
											{
												Key:      metav1.ObjectNameField,
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"node_1"},
											},
										},
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "foo",
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"bar"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			nodeName: "node_2",
			labels:   map[string]string{"foo": "bar"},
			want:     false,
		},
		{
			name: "Pod with one term: both matchFields and matchExpressions match",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchFields: []core.NodeSelectorRequirement{
											{
												Key:      metav1.ObjectNameField,
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"node_1"},
											},
										},
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "foo",
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"bar"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			nodeName: "node_1",
			labels:   map[string]string{"foo": "bar"},
			want:     true,
		},
		{
			name: "Pod with two terms: both matchFields and matchExpressions do not match",
			pod: &core.Pod{
				Spec: core.PodSpec{
					Affinity: &core.Affinity{
						NodeAffinity: &core.NodeAffinity{
							RequiredDuringSchedulingIgnoredDuringExecution: &core.NodeSelector{
								NodeSelectorTerms: []core.NodeSelectorTerm{
									{
										MatchFields: []core.NodeSelectorRequirement{
											{
												Key:      metav1.ObjectNameField,
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"node_1"},
											},
										},
									},
									{
										MatchExpressions: []core.NodeSelectorRequirement{
											{
												Key:      "foo",
												Operator: core.NodeSelectorOpIn,
												Values:   []string{"not-match-to-bar"},
											},
										},
									},
								},
							},
						},
					},
				},
			},
			nodeName: "node_2",
			labels:   map[string]string{"foo": "bar"},
			want:     false,
		},
	}

	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			node := core.Node{ObjectMeta: metav1.ObjectMeta{
				Name:   test.nodeName,
				Labels: test.labels,
			}}
			got, _ := PodMatchesNodeAffinity(test.pod, &node)
			if test.want != got {
				t.Errorf("expected: %v got %v", test.want, got)
			}
		})
	}
}

// from corev1/helpers_test.go
func TestMatchNodeSelectorTerms(t *testing.T) {
	type args struct {
		nodeSelector *core.NodeSelector
		node         *core.Node
	}

	tests := []struct {
		name string
		args args
		want bool
	}{
		{
			name: "node label matches matchExpressions terms",
			args: args{
				nodeSelector: &core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
					{
						MatchExpressions: []core.NodeSelectorRequirement{{
							Key:      "label_1",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"label_1_val"},
						}},
					},
				}},
				node: &core.Node{ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"label_1": "label_1_val"}}},
			},
			want: true,
		},
		{
			name: "node field matches matchFields terms",
			args: args{
				nodeSelector: &core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
					{
						MatchFields: []core.NodeSelectorRequirement{{
							Key:      "metadata.name",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"host_1"},
						}},
					},
				}},
				node: &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "host_1"}},
			},
			want: true,
		},
		{
			name: "invalid node field requirement",
			args: args{
				nodeSelector: &core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
					{
						MatchFields: []core.NodeSelectorRequirement{{
							Key:      "metadata.name",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"host_1", "host_2"},
						}},
					},
				}},
				node: &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "host_1"}},
			},
			want: false,
		},
		{
			name: "fieldSelectorTerm with node labels",
			args: args{
				nodeSelector: &core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
					{
						MatchFields: []core.NodeSelectorRequirement{{
							Key:      "metadata.name",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"host_1"},
						}},
					},
				}},
				node: &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "not_host_1", Labels: map[string]string{
					"metadata.name": "host_1",
				}}},
			},
			want: false,
		},
		{
			name: "labelSelectorTerm with node fields",
			args: args{
				nodeSelector: &core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
					{
						MatchExpressions: []core.NodeSelectorRequirement{{
							Key:      "metadata.name",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"host_1"},
						}},
					},
				}},
				node: &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "host_1"}},
			},
			want: false,
		},
		{
			name: "labelSelectorTerm and fieldSelectorTerm was set, but only node fields",
			args: args{
				nodeSelector: &core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
					{
						MatchExpressions: []core.NodeSelectorRequirement{{
							Key:      "label_1",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"label_1_val"},
						}},
						MatchFields: []core.NodeSelectorRequirement{{
							Key:      "metadata.name",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"host_1"},
						}},
					},
				}},
				node: &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "host_1"}},
			},
			want: false,
		},
		{
			name: "labelSelectorTerm and fieldSelectorTerm was set, both node fields and labels (both matched)",
			args: args{
				nodeSelector: &core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
					{
						MatchExpressions: []core.NodeSelectorRequirement{{
							Key:      "label_1",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"label_1_val"},
						}},
						MatchFields: []core.NodeSelectorRequirement{{
							Key:      "metadata.name",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"host_1"},
						}},
					}},
				},
				node: &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "host_1",
					Labels: map[string]string{
						"label_1": "label_1_val",
					}}},
			},
			want: true,
		},
		{
			name: "labelSelectorTerm and fieldSelectorTerm was set, both node fields and labels (one mismatched)",
			args: args{
				nodeSelector: &core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
					{
						MatchExpressions: []core.NodeSelectorRequirement{{
							Key:      "label_1",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"label_1_val"},
						}},
						MatchFields: []core.NodeSelectorRequirement{{
							Key:      "metadata.name",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"host_1"},
						}},
					},
				}},
				node: &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "host_1",
					Labels: map[string]string{
						"label_1": "label_1_val-failed",
					}}},
			},
			want: false,
		},
		{
			name: "multi-selector was set, both node fields and labels (one mismatched)",
			args: args{
				nodeSelector: &core.NodeSelector{NodeSelectorTerms: []core.NodeSelectorTerm{
					{
						MatchExpressions: []core.NodeSelectorRequirement{{
							Key:      "label_1",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"label_1_val"},
						}},
					},
					{
						MatchFields: []core.NodeSelectorRequirement{{
							Key:      "metadata.name",
							Operator: core.NodeSelectorOpIn,
							Values:   []string{"host_1"},
						}},
					},
				}},
				node: &core.Node{ObjectMeta: metav1.ObjectMeta{Name: "host_1",
					Labels: map[string]string{
						"label_1": "label_1_val-failed",
					}}},
			},
			want: true,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			if got, _ := nodeSelectorsMatchesNodeAffinity(*tt.args.nodeSelector, tt.args.node); got != tt.want {
				t.Errorf("MatchNodeSelectorTermsORed() = %v, want %v", got, tt.want)
			}
		})
	}
}