Review analyzer Description, Message, and Category #85
Labels
analyzers
Change that impacts an analyzer behavior
housekeeping
.NET
Pull requests that update .net code
Milestone
Comments
MattKotsenas
added a commit
that referenced
this issue
Jun 13, 2024
…es (#86) Fix RS1032 by removing the period from the end of the analyzer messages. I also inlined the constants into the appropriate analyzer class instead of in a shared constants class. This makes future refactoring of the tests easier, as now the analyzer's ID is part of the analyzer itself. I also filed #85 to track potential changes to our message and categories.
rjmurillo
added
housekeeping
.NET
rjmurillo
added a commit
that referenced
this issue
Jul 14, 2024
…ldMatchAnalyzer (#140) The majority of this change is mechanical (moving code from one location to another, replacing magic strings with constants, etc.). There is a functional update that completely changes the `ConstructorArgumentsShouldMatchAnalyzer`: - consolidating two constructor analyzers now into a single shared source - improving the performance of the constructor analyzer - adding support for checking delegate - adding support for `Mock.Of<T>` and `MockRepository` features of `Moq`  _Baseline is an empty analyzer, control is the old interface constructor parameter analyzer, treatment is the new combined analyzer._ Changes Misc: - Reduced severity of AV analyzer items (see #139) - Move magic strings to constants - Moved much of the common code into a `Common` folder and namespace Documentation: - Fixed links to documentation for shipped analyzers - In analyzer rule help, link to commit id so documentation snaps to the version of the analyzer Analyzers: - Moved rule ID to constants file - Added extension factory methods to help create `Diagnostic` - Consolidated two constructor parameter analyzers (Moq1001 and Moq1002) into a single analyzer with 30% better performance - `ConstructorArgumentsShouldMatchAnalyzer` now supports `Mock.Of<T>` syntax and `MockRepository` patterns Benchmarks: - Add the ability to have a control and treatment as well as "baseline", allowing A/B performance benchmarking of implementations - Added benchmark for `ConstructorArgumentsShouldMatchAnalyzer` Test: - Added extension methods to include all Moq versions under test or just the latest - Organized the `ConstructorArgumentsShouldMatchAnalyzer` test collateral (it's the highest volume) into partial files - Added Live Unit Test configuration when running in Visual Studio - Added code coverage filter for benchmark code if using ReSharper or Rider _Note: while code coverage is improved, it's still below 95%. This is due to some guard cases that need coverage. For example, #141_ Resolves #122 For Moq1001 and Moq1002, #85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure we're following best practices for the strings for analyzers.
Messagedoesn't accept any format strings, it probably belongs inDescriptioninsteadMessagethat includes the text of whatever's incorrect (via the{0}format strings)The text was updated successfully, but these errors were encountered: