Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PaliGemma module to align with Florence-2 structure and functionality #45

Open
9 tasks
SkalskiP opened this issue Sep 16, 2024 · 0 comments · May be fixed by #44
Open
9 tasks

Refactor PaliGemma module to align with Florence-2 structure and functionality #45

SkalskiP opened this issue Sep 16, 2024 · 0 comments · May be fixed by #44
Labels
enhancement New feature or request

Comments

@SkalskiP
Copy link
Collaborator

SkalskiP commented Sep 16, 2024

Description

The PaliGemma module is currently incomplete and not ready for use. We aim to refactor the PaliGemma codebase to align with the structure and functionality of the Florence_2 module. This involves updating the code structure, implementing a command-line interface (CLI) using typer, documenting the code thoroughly, and ensuring the module is fully operational.

Acceptance Criteria

  • Code Restructuring:
    • Organize the PaliGemma codebase to mirror the Florence-2 module structure. Making appropriate changes if necessary.
    • Create necessary submodules such as core.py, entrypoint.py, checkpoints.py, etc.
  • Implement CLI with typer.
  • Update training and evaluation logic. Refactor training loops, data loaders, and model preparation to match Florence-2 tracking. Due to model-specific requirements, custom data loaders may be needed. Make sure they accept data in JSONL format.
  • Add Documentation:
    • Write comprehensive docstrings for all user-facing classes, functions, and methods.
    • Ensure code is well-commented and follows PEP 8 guidelines.
  • Validate the training and evaluation processes end-to-end. Provide a notebook showing usage example.
@SkalskiP SkalskiP added the enhancement New feature or request label Sep 16, 2024
@SkalskiP SkalskiP linked a pull request Sep 16, 2024 that will close this issue
4 tasks
@SkalskiP SkalskiP changed the title [PaliGemma] - add maestro support Refactor PaliGemma Module to Align with Florence_2 Structure and Functionality Sep 16, 2024
@SkalskiP SkalskiP changed the title Refactor PaliGemma Module to Align with Florence_2 Structure and Functionality Refactor PaliGemma module to align with Florence-2 structure and functionality Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant