Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E: buildarch-instead-of-exclusivearch-tag noarch #698

Open
DimStar77 opened this issue Sep 2, 2021 · 5 comments
Open

E: buildarch-instead-of-exclusivearch-tag noarch #698

DimStar77 opened this issue Sep 2, 2021 · 5 comments
Labels

Comments

@DimStar77
Copy link
Contributor

DimStar77 commented Sep 2, 2021

rpmlint reports an error like

E: buildarch-instead-of-exclusivearch-tag noarch
Use ExclusiveArch instead of BuildArch (or BuildArchitectures) to restrict
build on some specific architectures. Only use BuildArch with noarch

As can be identified from the error message already, the packager obviously did use noarch. So that error is a false-positive

@Conan-Kudo
Copy link
Member

It sounds like this error triggered with ExclusiveArch: noarch?

@DimStar77
Copy link
Contributor Author

unlikely:

> osc cat openSUSE:Factory libreoffice libreoffice.spec | grep -i noarch
BuildArch:      noarch
BuildArch:      noarch
BuildArch:      noarch
BuildArch:      noarch
%define _link_noarch_files() \
BuildArch:      noarch \
%{expand:%%_link_noarch_files %{pkgname}} \
# compat stuff for noarch packages
# helper script for noarch packages
# Move split noarch data to share
# create symlinks for all brandings to noarch pkg
%_link_noarch_files icon-themes

@DimStar77
Copy link
Contributor Author

It sounds like this error triggered with ExclusiveArch: noarch?

The error says I should USE ExclusiveArch, which is not correct in the case of noarch

@Conan-Kudo
Copy link
Member

🤦🏾‍♂️

@Conan-Kudo Conan-Kudo added the bug label Sep 2, 2021
@marxin marxin self-assigned this Sep 2, 2021
@marxin
Copy link
Contributor

marxin commented Sep 2, 2021

Well, the full error message is:
[16716s] libreoffice.spec:805: E: buildarch-instead-of-exclusivearch-tag noarch \

note the trailing \ and it comes from a huge macro:

%define make_autocorr_aliases(l:) \
...
Provides:       locale(libreoffice:%{lang}) \
BuildArch:      noarch \
%{-m:Requires: myspell-%{-m*}}%{!-m:%{-M:Requires: myspell-%{lang}}} \
...

Well, we can't probably do much, the check works on text input of the .spec file.

@marxin marxin removed their assignment Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants