-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENV variables not loaded with config #321
Comments
Similar issue here:
Contents of # set up config to look for ENV[key] instead of Settings.key
Config.setup do |config|
config.use_env = true
end rails console does not load into ENV namespace: $ rails c
Loading development environment (Rails 5.1.7)
[1] pry(main)> ENV['database_host']
=> nil
[2] pry(main)> Settings.database_host
=> "localhost" |
After review I believe this is expected behavior as the gem is just trying to read from |
Yes @harrisjb we do not populate things back into ENV, we only read from it. So your reported issue is not valid. |
However what @deepakmahakale posted should work. @cjlarose any idea why it does not? |
I agree that what @deepakmahakale posted should work. @deepakmahakale if you're able to reproduce the issue on a new rails app, we can take a deeper look into what's going on. |
I am having the same issue as @deepakmahakale , in a new Rails app:
.env
I tried downgrading to config gem 2.2, but without luck. I have another project using that version (with Rails 6.1.4.1, Ruby 2.7.4.) successfully. Happy to try anything if you have any recommendations, thank you. |
@jfadgen, @deepakmahakale, I ran into a similar issue in a recent rails project and figured out that the problem is that ENV variables haven't been loaded yet when the config initializer runs if you're using specifically, if you're loading from a according to https://github.com/bkeepers/dotenv:
note that if you're using something like heroku, where the env vars are set on the servers, they will likely be available for the initializers. so you may only need to do this for your dev and test environments. @pkuczynski I think you guys should think about adding support for .env files - if they're detected, your gem should automatically try to load the contents of |
The whole concept of this gem is to store config in the per env configuration files. Using .env and gems like dotenv is a different approach for doing the same thing. They kind of contradictory to each other. So I am not sure if we should support this. @cjlarose what do you think? |
yeah, I see what you're saying, but the issue is that a lot of teams use so, you're kind of leaving the door open to a lot of confusion if you don't support env vars being preloaded thru something like dotenv, which is a very popular tool. for me, I wanted to use this gem primarily to store certain configs in a yml file format, which allows for nesting keys and other advantages over long, messy .env files. however, I also wanted to be able to override default values in that yml file thru env vars (i.e. on heroku). this allows me to change these configs without committing new yml files. I think that's a legitimate use case. but in any case, you guys should at least add a disclaimer about this scenario in the README, since I'm sure others have ran into this issue |
Worth noting that the issue went away for me after changing my Gemfile to bundle |
@jfadgen I in fact saw this issue while using |
actually, I just discovered that you can require
this will ensure that dotenv files are loaded before initializers and solve this issue. I think modifying the gemfile is preferable to messing with |
For anyone else coming into this issue and seeing @nick-reshetnikov 's solution, you'll get a warning w/ latest version that
edit: it appears that if your gem is in development/test group, if you try to do a production build it will still try to do the require even though it's in that group, resulting in a LoadError (this might be a bundler bug with specific versions...). So you can either add to application initializer config per the comment above Or also you can create a file in your /config/initializers that begins with letter after "d", eg "reload_config.rb" and do:
to force Config gem to reload and pickup the ENV values now populated from .env file after dotenv is autoloaded. |
I followed this but I am unable to access the environment variable with
Settings
config.rb
SETTINGS__SECTION__SERVER_SIZE=1 SETTINGS__SECTION__SERVER=google.com SETTINGS__SECTION__SSL_ENABLED=false rails c
The text was updated successfully, but these errors were encountered: