Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PACKS] 14 -- add custom units to request confirmation page. #4576

Open
2 tasks
cielf opened this issue Aug 4, 2024 · 4 comments
Open
2 tasks

[PACKS] 14 -- add custom units to request confirmation page. #4576

cielf opened this issue Aug 4, 2024 · 4 comments

Comments

@cielf
Copy link
Collaborator

cielf commented Aug 4, 2024

Summary

This is a late add-on to the packs stream -- we are adding in a request confirmation page, and it will need to be modified to take custom units into account

Details

This should be a similar formatting of the item information as in the request details page.

The request confirmation page will probably get merged before the rest of PACKS is ready
Don't have a screenshot yet

NOTE: Depends on the PR #4553, which should be in very soon.

Criteria for completion

  • request confirmation page takes into account the custom units, similar to the request view.
  • tests to confirm
@cielf cielf added Difficulty—Beginner Help Wanted Groomed + open to all! labels Aug 4, 2024
@cielf cielf added this to the Request Units (Packs) milestone Aug 5, 2024
@prasath1196
Copy link

@cielf - I would like to take this up. Can you assign it to me?

@cielf
Copy link
Collaborator Author

cielf commented Aug 11, 2024

Sure!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Aug 11, 2024
@awwaiid
Copy link
Collaborator

awwaiid commented Aug 25, 2024

Are you still looking at this @prasath1196? If not ... I am on a roll with these and can pick it up :)

@prasath1196
Copy link

prasath1196 commented Aug 30, 2024

Hi @awwaiid - Will be fixing this in the next two days. Feel free to pickup if you want to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants