Restrict phone number field to the telephone input #192 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garettarrowood We added a simple validation for presence and for a length. Before we update the specs we wanted clarification on the phone number format. Right now we don't allow any space between the digits or any |
|
Our If you'd like to continue to work on this, please cherry-pick these two commits and open up a fresh PR. Sorry for the inconvenience! In regards to your question, I believe one solution may be to strip all cc/ @RudeChowder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #192
Description
This PR is adding validation on
phone_number. Number can not be blank and must be 10 digits long.Before we move on and add specs we need clarification on the phone number format. Format we added does not allow any space or
-between the digits. Once we clarify that is a format we want we will go ahead and add specs for student and user model as well.Type of change
Screenshots