Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display artifact dependency information in cargo tree #14804

Open
weihanglo opened this issue Nov 9, 2024 · 1 comment · May be fixed by #14658
Open

Display artifact dependency information in cargo tree #14804

weihanglo opened this issue Nov 9, 2024 · 1 comment · May be fixed by #14658
Labels
Command-tree S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. Z-bindeps Nightly: binary artifact dependencies

Comments

@weihanglo
Copy link
Member

Some questions I asked in #10593 (comment):

  • Should we annotate artifact dependency nodes with a special (artifact deps) suffix?
  • Should we show the information about which target platform an artifact dependency will be built on?
  • How do we want to display the node of an artifact dependency with { …, lib = true }?

And some replies from @bstrie

Should we annotate artifact dependency nodes with a special (artifact deps) suffix?

There are multiple possible values for the artifact field, so I wouldn't mind having a (bin) or (staticlib) or (cdylib) suffix.

Should we show the information about which target platform an artifact dependency will be built on?

No, I think that's a detail that can be easily answered by checking Cargo.toml. But if you did decide to display this information, I would include it as part of the above annotation, e.g. (wasm32-wasi bin) or (x86_64-unknown-linux-musl staticlib).

How do we want to display the node of an artifact dependency with { …, lib = true }?

I think it should show up multiple times in the tree graph. The lib node should show up as an entirely normal dependency, whereas the artifact node should be annotated as mentioned above.

Propose solution

Since this is an unstable, we can ship an initial version and iterate on it then.

Version

d8cb5fb

@weihanglo weihanglo added Command-tree S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. Z-bindeps Nightly: binary artifact dependencies labels Nov 9, 2024
@weihanglo
Copy link
Member Author

There is a draft PR for this #14658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Command-tree S-needs-design Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted. Z-bindeps Nightly: binary artifact dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant