Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal - Reporters for JSON and HTML #1

Open
hadrien-toma opened this issue May 29, 2021 · 2 comments
Open

Feature proposal - Reporters for JSON and HTML #1

hadrien-toma opened this issue May 29, 2021 · 2 comments

Comments

@hadrien-toma
Copy link

hadrien-toma commented May 29, 2021

Description

I would like to add this young but already very nice tool on my CI and it would be awesome if a flag allows us to specify that we want a not live output, as JSON and HTML 😋

Usage suggestion

JSON reporter

  • This JSON would be useful as a data source for other use cases (data processings) or visualizations
yarn run import-graph-visualizer \
    --no-browser-open \
    --report=json \
    --outputPath=dist/my-branch-name \
    --targets="apps/my-app/src/app/app.module.ts" \
    --sources=""

HTML reporter

  • As a code reviewer, I would like to quickly look at the difference introduced by the commit I am reviewing in term of imports in order to have the opportunity to visually identify an anomaly or a dissonance. For this use case, as the human eye is the added value, an HTML output is very nice.
yarn run import-graph-visualizer \
     --no-browser-open \
     --report=html \
     --outputPath=dist/my-branch-name \
     --targets="apps/my-app/src/app/app.module.ts" \
     --sources=""

Note

Thank you for developing and sharing import-graph-visualizer 🙏 ❤️

@hadrien-toma hadrien-toma changed the title Feature request / Reporters JSON and HTML Feature proposal - Reporters for JSON and HTML May 29, 2021
@BioPhoton
Copy link
Member

BioPhoton commented May 31, 2021

Would you be interested in serving a PR? 😁

@hadrien-toma
Copy link
Author

hadrien-toma commented May 31, 2021

Hum it will depend on the amount of work to do but I would be pleased to! Maybe we can split this issue into different features?

Concerning the ability to save the served app, do you already have an idea of a clean implementation? This is the most important for me so I would like to implement this one prioritarly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants