Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twython.callback_url does not exist #552

Open
jvanasco opened this issue Aug 23, 2023 · 2 comments
Open

Twython.callback_url does not exist #552

jvanasco opened this issue Aug 23, 2023 · 2 comments

Comments

@jvanasco
Copy link
Contributor

This error popped up while working on a project that subclasses this.

There is a backup function to invoke self.callback_url on the Twython class, however that attribute is never assigned or defined.

Looking at the history of the project, I think this was marked for deprecation in 2011 and removed in 2013, but this reference somehow remained.

twython/twython/api.py

Lines 359 to 361 in 0c40560

# Use old-style callback argument if server didn't accept new-style
if callback_url and not oauth_callback_confirmed:
auth_url_params['oauth_callback'] = self.callback_url

@ryanmcgrath
Copy link
Owner

Wow! Talk about ancient history. How were you triggering this - just a standard OAuth flow?

@jvanasco
Copy link
Contributor Author

I have a project that integrates oauthlib into the Pyramid framework. I based the client class for the tests on Twython.

I was updating it with typing support, and one of the linters picked this up. I think mypy. I traced it back to Twython, then audited your code and the repo's history -- and found the tickets where a bunch of this stuff was reorganized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants