Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serendipity_event_freetag: uninitialized array #858

Open
bauigel opened this issue Oct 27, 2024 · 1 comment
Open

serendipity_event_freetag: uninitialized array #858

bauigel opened this issue Oct 27, 2024 · 1 comment

Comments

@bauigel
Copy link

bauigel commented Oct 27, 2024

Seems there is an uninitialized array in the code which breaks the rss-feed

Around line 693

$eventData['display_dat'] .= $this->getFeedXmlForTags('category', $eventData['properties']['freetag_tags'] ?? []);

Changed it to following (thanks to ChatGPT) and it seems to work (for me)

$eventData['display_dat'] = ($eventData['display_dat'] ?? '') . $this->getFeedXmlForTags('category', $eventData['properties']['freetag_tags'] ?? []);
@onli
Copy link
Member

onli commented Jan 18, 2025

Your proposed fix looks perfectly fine to me. There is a second occurrence of that array access a bit below, I fixed it equally. s9y/additional_plugins#171 is the PR, could you give it a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants