Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AbiType to type v1.3.0 contracts #582

Closed
dasanra opened this issue Nov 13, 2023 · 0 comments · Fixed by #604
Closed

Use AbiType to type v1.3.0 contracts #582

dasanra opened this issue Nov 13, 2023 · 0 comments · Fixed by #604
Assignees
@DaniSomoza

Comments

@dasanra
Copy link
Collaborator

dasanra commented Nov 13, 2023

Context / issue

The current typing library is deprecated and this prevent us to update to Web3.js v4. Also it's way more complex than current solutions adding more complexity to the SDK maintenance.

#577

Proposed solution

As there are quite some contracts to make compatible we think it's better to do it iteratively. We will start migrating v1.3.0 contracts to use AbiType as both alternatives can exist at the same time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaniSomoza DaniSomoza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(protocol-kit): Add Abitype for contract types and use EIP-1193 safe-global/safe-core-sdk
3 participants
@rmeissner @dasanra @DaniSomoza