Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EIP712 version in domain hash #920

Open
BigMurry opened this issue Feb 28, 2025 · 0 comments
Open

Add support for EIP712 version in domain hash #920

BigMurry opened this issue Feb 28, 2025 · 0 comments

Comments

@BigMurry
Copy link

Context / issue

Currently, when offline signing EIP712 messages, the domain hash only includes the chain ID and verifyContract. If users are unsure whether they have previously signed potentially dangerous messages and wish to invalidate all historical signed messages at once, there is no quick method to achieve this. The only solutions are to either replace the Safe contract address or change the signer, both of which are highly inefficient.

Proposed solution

The solution can be resolved by introducing a user-customizable version string into the EIP712 domain hash. Once the Safe contract allows users to configure this value, it can be recommended that users periodically update this version identifier in the future. By doing so, all previously signed messages tied to older versions would be invalidated in one go, achieving risk isolation and future-proofing their security posture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant