Messages History changing based on Ownership

[ru513]

Bug description

The n-out-of-n message is taking the current signer make up, not the historical settings at the time of the message.

The messages in the screenshot were all fully signed, after changing removing signers they are shown as incomplete / waiting for another signer.

In the screenshot you can see the 3/3 signatures at the time of the change in ownership, with 2/3 before, in actual fact all are 3/3.

Environment

• Browser: Chrome
• Wallet: N/A
• Chain: Ethereum mainnet
• Safe: https://app.safe.global/transactions/messages?safe=eth:0x0bC46509AC0689bBEBA653ebF207A2a0CB3F5EFb

Steps to reproduce

Go to https://app.safe.global/transactions/messages?safe=eth:0x0bC46509AC0689bBEBA653ebF207A2a0CB3F5EFb

Expected result

After changing signers , messages should be remain as complete and historical transactions shouldn't change.

Obtained result

Messages history shown as waiting for an additional signature

Screenshots

[liliya-soroka]

not a bug. This is how the feature work. If the owner is removed ( example: if the owner was compromised and was replaced by another one), his signature is removed for the messages and txs in queued list .
I will convert the ticket to the feature request to discuss with product team

[katspaugh]

I've just double-checked and I don't see the described behavior in the transaction history (didn't test message history).

[ru513]

@katspaugh Shouldn't have mentioned tx history here, it only concerns messages, you can see on the screenshot here this label is inaccurate if the signer makeup changes.

I think we should address this if we are showing inaccurate information.