fix bash execution issues #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes execution issues mentioned in samsalisbury#1 for both linux and macos runners fixes samsalisbury#1
Namek
reviewed
Nov 19, 2020
| @@ -19,7 +19,6 @@ commands: | |||
| when: <<parameters.when>> | |||
| name: "GitHub Status: <<parameters.state>>" | |||
| command: | | |||
| set -euo pipefail | |||
There was a problem hiding this comment.
is it breaking something? Wasn't the plan to actually call set +u here?
There was a problem hiding this comment.
set +u seems to be unnecessary, because it's never -u. Also neither are other flags, since it looks like cci runs bash with -eo pipefall flags by default.
nice explanation: https://gist.github.com/mohanpedala/1e2ff5661761d3abd0385e8223e16425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes execution issues mentioned in #1 for both linux and macos runners
fixes #1