Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding docker? #311

Open
fommil opened this issue Nov 14, 2024 · 3 comments
Open

consider adding docker? #311

fommil opened this issue Nov 14, 2024 · 3 comments

Comments

@fommil
Copy link

fommil commented Nov 14, 2024

Hi, thanks for your efforts here, they are really appreciated. I used to maintain these sorts of things years ago, it has always been a huge gap in the whole community that these things didn't exist.

A lot of builds use sbt-docker to spin up integration tests, or sbt-native-packager to produce docker outputs. I would go so far as to say that it's standard practice nowadays to do this for anything except a published library jar.

Would you be open to adding the docker binary (and possibly even docker-compose, although that is perhaps more niche) to your base images to accommodate that very common usecase?

It's no big thing if you say no, your images already provide a great base for teams to add their build deps onto.

@fommil fommil closed this as completed Nov 14, 2024
@fommil fommil reopened this Nov 14, 2024
@eed3si9n
Copy link
Member

Yo dawg I heard you like cgroups?

what are the potential pros and cons? would people be able to run it without the privilege mode of they don't need to build a docker image?

@francisdb
Copy link
Collaborator

Personally not a fan of adding more stuff.
Creating your own image that starts with this one and adds the docker layer should not be that hard?

@fommil
Copy link
Author

fommil commented Nov 14, 2024

@eed3si9n I enjoy all kinds of groups!

I don't believe there would be any additional requirement for people using it as-is. Privileged mode or passing a socket through would only be necessary when spawning a new container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants