Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizer knob on every cell in column #180

Open
jackie-benowitz opened this issue Jun 22, 2017 · 3 comments
Open

Resizer knob on every cell in column #180

jackie-benowitz opened this issue Jun 22, 2017 · 3 comments
Labels
enhancement v2.0-beta Tickets targeting the v2.0-beta branch.
Milestone

Comments

@jackie-benowitz
Copy link

Expected Behavior

When a column is marked as resizable, it'll be useful to have a knob on every cell in a column to allow for resizing, not just the Header cell.

Current Behavior

Right now the Resizer Knob only shows up on the Header cell for the column. If you need to resize a column, you need to find the Header, however this will grow all the cells beneath it and the group header above it.

Possible Solution

I'm not too far into reading the code, but I'm attempting to see how the header cell is rendered differently than the others, and apply that change to the other cells.

Your Environment

  • Version used: Currently on actually normal fixed-data-table, but looking to upgrade to this.
  • Link to your project: indicative.com
@wcjordan
Copy link
Member

Hey @jackie-benowitz, this is an interesting idea. I think the way we'd prefer to approach it would be to make the resize knob a reusable component which users could easily add to their cells.

Right now the resize component is added as part of FixedDataTableCell here. To get things off the ground quickly, I'd recommend trying to fork the repo and add the onColumnResize prop to rows here, similar to how it's added to headers here and here. Note you'll probably need to pass things down through the FixedDataTableBufferedRows component here.

For the longer term, if you want to put that functionality behind a new prop and put up a pull request, I think we would accept that. The reusable component aspect I mentioned above would probably be longer term as we refactor the codebase to be more composable.

@jackie-benowitz
Copy link
Author

Great thanks! I'm surprised no one has asked for it already!

@wcjordan wcjordan added this to the 1.2 milestone May 4, 2020
@wcjordan
Copy link
Member

wcjordan commented May 4, 2020

Our new work for more flexible resizing should support this in a future release. It won't come out of the box, but we will provide an easier to work w/ API and some examples which should get us most of the way to this.

@pradeepnschrodinger pradeepnschrodinger added the v2.0-beta Tickets targeting the v2.0-beta branch. label Jun 6, 2022
@pradeepnschrodinger pradeepnschrodinger modified the milestones: v1.2, v2.0 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement v2.0-beta Tickets targeting the v2.0-beta branch.
Projects
None yet
Development

No branches or pull requests

3 participants