Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Testingframework from mocha/chai to jest and add more tests #292

Open
Flui opened this issue Feb 4, 2018 · 2 comments
Open

Change Testingframework from mocha/chai to jest and add more tests #292

Flui opened this issue Feb 4, 2018 · 2 comments

Comments

@Flui
Copy link
Contributor

Flui commented Feb 4, 2018

Expected Behavior

Write fast Unit- and Snapshottests with less configuration.

Current Behavior

For now there is a test-helper needed and

Possible Solution

install jest and refactor tests to work with jest

Context

This helps to provide almost 100% code coverage for testing. It is much easier to recognize if and in which way changes affect the rendered html.

@KamranAsif
Copy link
Contributor

This isn't really a bug since there isn't anything wrong with mocha/chai.
That being said, feel free to open a PR switching to Jest and I'm sure the team will consider it

@wcjordan
Copy link
Member

wcjordan commented Feb 5, 2018

+1 to Kam's suggestion to open a PR. I don't think we need to switch frameworks, but adding some jest snapshot testing would be great. THanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants