Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing random state in Quantile Regression #405

Open
gmartinonQM opened this issue Jan 25, 2024 · 2 comments
Open

Missing random state in Quantile Regression #405

gmartinonQM opened this issue Jan 25, 2024 · 2 comments
Assignees
@LacombeLouis @thibaultcordier
Labels
MAPIE v1 Indicate that the issue will be resolved with the release of MAPIE v1 Other or internal If no other grey tag is relevant or if issue from the MAPIE team

Comments

@gmartinonQM
Copy link
Collaborator

I am trying to get reproducible results with MapieQuantileRegressor with the "split" method. Unfortunately :

TypeError: MapieQuantileRegressor.__init__() got an unexpected keyword argument 'random_state'

Whereas the attribute random_state is indeed used in the code of MapieQuantileRegressor, but always with the default value None. (

MAPIE/mapie/regression/quantile_regression.py

Line 391 in 2681b82

random_state=random_state,
)

Could you please add the random_state in the constructor of MapieQuantileRegressor ?
@LacombeLouis
Copy link
Collaborator

Hi @gmartinonQM, thank you for this information.
If you want replicable results for the moment, I would suggest using the random_state in the .fit method. However, this is indeed something we should change to have it in the .__init__() of the method.
Thank you!

@LacombeLouis LacombeLouis added bug Good first issue Easy issue to start to contribute to MAPIE and removed enhancement labels Jan 26, 2024
@tiagoleonmelo tiagoleonmelo mentioned this issue Mar 22, 2024
Closed
8 tasks
@github-actions github-actions bot mentioned this issue Jun 24, 2024
Open
@jawadhussein462 jawadhussein462 added MAPIE v1 Indicate that the issue will be resolved with the release of MAPIE v1 Regression Related to regression (excluding time series) Discussion in progress Discussion ongoing between the Mapie team and the author. Needs decision The MAPIE team is deciding what to do next. and removed MAPIE v1 Indicate that the issue will be resolved with the release of MAPIE v1 Discussion in progress Discussion ongoing between the Mapie team and the author. labels Nov 7, 2024
@Valentin-Laurent Valentin-Laurent added Backlog This is in the MAPIE team development backlog, yet to be prioritised. and removed Needs decision The MAPIE team is deciding what to do next. labels Nov 18, 2024
@Valentin-Laurent Valentin-Laurent added MAPIE v1 Indicate that the issue will be resolved with the release of MAPIE v1 and removed Backlog This is in the MAPIE team development backlog, yet to be prioritised. labels Jan 13, 2025
@Valentin-Laurent
Copy link
Collaborator

Hello, in MAPIE v1, data splitting will be left to the user, so the random_state controlling this will be of no use.

@Valentin-Laurent Valentin-Laurent added Other or internal If no other grey tag is relevant or if issue from the MAPIE team and removed Good first issue Easy issue to start to contribute to MAPIE Regression Related to regression (excluding time series) Bug labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LacombeLouis LacombeLouis

@thibaultcordier thibaultcordier

Labels
MAPIE v1 Indicate that the issue will be resolved with the release of MAPIE v1 Other or internal If no other grey tag is relevant or if issue from the MAPIE team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add random state to MapieQuantileRegressor constructor tiagoleonmelo/MAPIE
5 participants
@Valentin-Laurent @jawadhussein462 @gmartinonQM @LacombeLouis @thibaultcordier