Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sherlock as a python library #2293

Closed
1 task done
peterclemenko opened this issue Sep 12, 2024 · 1 comment
Closed
1 task done

sherlock as a python library #2293

peterclemenko opened this issue Sep 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@peterclemenko
Copy link

Description

being able to use sherlock as a library in python scripts would be helpful for automation flows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@peterclemenko peterclemenko added the enhancement New feature or request label Sep 12, 2024
@ppfeister
Copy link
Member

Already doable!

I've done the same as a dependency of Sylva (ongoing). You can see how it was implemented here.

I have plans to clean up the imports a bit, so that you can do from sherlock_project ... rather than from sherlock_project.sherlock ..., but that's down the line. Type defs are mostly there if you use static type validation, with #2277 (soon, need to push a change) set to add ~proper~ support for type checks with things like mypy.

Proper documentation for use as a dependency will probably be added at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants