Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected transition when commenting a line #23

Open
simjnd opened this issue Aug 22, 2024 · 1 comment
Open

Unexpected transition when commenting a line #23

simjnd opened this issue Aug 22, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed pr welcome

Comments

@simjnd
Copy link

simjnd commented Aug 22, 2024

How to reproduce

  1. Go to the Shiki Magic Move Demo (https://shiki-magic-move.netlify.app/)
  2. Comment the import { defineComponent } from 'vue' line
  3. Notice a lot of things unexpectingly shuffling around (like the > of a closing paragraph tag several lines down
    For a more dramatic example you can check the Zig example on the same page and comment line 12 defer list.deinit();, a lot more symbol names jump around

Expected Behaviour
In the case of commenting / decommenting a line I feel like the transition should be really simple, the line should just shift with the addition of the comment symbol and the color should fade

@antfu antfu added the bug Something isn't working label Aug 22, 2024
@antfu
Copy link
Member

antfu commented Aug 22, 2024

Yeah the algorithm can be improved. I am counting on someone to help with a PR - so PR welcome :)

@antfu antfu added help wanted Extra attention is needed pr welcome labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed pr welcome
Projects
None yet
Development

No branches or pull requests

2 participants