Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS verification on OIDC Issuers #1665

Open
dandresm opened this issue May 19, 2024 · 2 comments
Open

TLS verification on OIDC Issuers #1665

dandresm opened this issue May 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dandresm
Copy link

dandresm commented May 19, 2024

Right now a typical OIDC Issuer config would look like this:

"https://keycloak.local/sigstore-realm": { "IssuerURL": "https://key cloak.local/sigstore-realm", "ClientID": "sigstore", "Type": "email" }

In our use case, using an internal OIDC provider causes x509 certificate verification failure, because the TLS certificate is signed by an internal CA. My proposal is adding an optional parameter (TlsVerify=false) for disabling TLS verification when interacting with some OIDC providers. It would be even better to pass the certificate as parameter in PEM format, so fulcio can trust this certificate.

@dandresm dandresm added the enhancement New feature or request label May 19, 2024
@haydentherapper
Copy link
Contributor

Feel free to submit a PR for this! I would recommend adding it as a configuration for an OIDC issuer.

@Sifungurux
Copy link

@dandresm are you working on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants