Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsite ID added to external https links in CMS preview #470

Open
sig-peggy opened this issue Oct 3, 2021 · 1 comment
Open

Subsite ID added to external https links in CMS preview #470

sig-peggy opened this issue Oct 3, 2021 · 1 comment

Comments

@sig-peggy
Copy link

In LeftAndMain_Subsites.js the function to inject the Subsite ID into internal links only checks for http:// to identify external links, so it's appending ?SubsiteID=n to all https:// links as well.

image

@michalkleiner
Copy link
Contributor

Good find. Also, it would seem like an insufficient check if it doesn't take into account the CMS domain/host at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants