Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spglib v2.2.0 has made changes that break some tests #178

Closed
singularitti opened this issue Dec 19, 2023 · 4 comments
Closed

Spglib v2.2.0 has made changes that break some tests #178

singularitti opened this issue Dec 19, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@singularitti
Copy link
Owner

singularitti commented Dec 19, 2023

Dear Spglib.jl users,

I would like to inform you of a recent issue encountered with Spglib.jl following an upgrade to spglib_jll.jl version v2.2.0+0. Some tests have failed post-upgrade, indicating potential compatibility or functional issues.

Upon initial investigation, I observed that corresponding Python code in Spglib has also undergone changes. This leads me to believe that the root of the problem might lie within the changes made to Spglib's underlying C code, rather than being specific to spglib_jll.jl & Spglib.jl alone.

Currently, I am unable to allocate time to debug this issue in detail. My next step is to reach out to the official Spglib development team for insights and possible solutions.

In the meantime, I recommend that users revert spglib_jll.jl to version v2.1.0+0 to ensure stability and avoid the issues presented by the latest update. I apologize for any inconvenience caused and appreciate your patience and understanding as we work towards resolving this matter.

Thank you for your cooperation.

@singularitti singularitti added the bug Something isn't working label Dec 19, 2023
@singularitti singularitti self-assigned this Dec 19, 2023
@singularitti
Copy link
Owner Author

@thchr
Copy link
Contributor

thchr commented Dec 20, 2023

How about just restricting spglib_jll to v2.1 in the Project.toml of Spglib.jl for the time being?

@singularitti
Copy link
Owner Author

I could, but I'm not sure if that is a bug or a feature yet. I need to have a look at what changes might cause it.

@singularitti
Copy link
Owner Author

Hi everyone, I have restricted spglib_jll.jl up to 2.1 in the latest release. We will re-enable 2.2.0+ in Spglib.jl in 0.10.0+ since it is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants