You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our router implementations for the restJson1 (see request_spec.rs) and rpcv2Cbor protocols rely on regexes.
We should consider code-generating a nom parser instead, which should be more performant. We already use nom parsers in restJson1 to extract @httpLabels from the URI (see #938), and some simple benchmarking found it to be ~200x faster ~200x faster.
It'd be interesting to tackle this after we have proper benchmarks (#214) to determine any performance impact.
The text was updated successfully, but these errors were encountered:
Our router implementations for the
restJson1
(seerequest_spec.rs
) andrpcv2Cbor
protocols rely on regexes.We should consider code-generating a
nom
parser instead, which should be more performant. We already usenom
parsers inrestJson1
to extract@httpLabel
s from the URI (see #938), and some simple benchmarking found it to be ~200x faster ~200x faster.It'd be interesting to tackle this after we have proper benchmarks (#214) to determine any performance impact.
The text was updated successfully, but these errors were encountered: