Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples dir refactor + cleanup #603

Open
wkozyra95 opened this issue Jul 1, 2024 · 0 comments
Open

examples dir refactor + cleanup #603

wkozyra95 opened this issue Jul 1, 2024 · 0 comments
Assignees

Comments

@wkozyra95
Copy link
Member

wkozyra95 commented Jul 1, 2024

The examples directory is intended for internal examples, because we do not expect most users to interact with server from rust.

  • Move examples from top-level create to integration_testing crate
  • Refactor the code, so you can
    • Run any example in docker (instead of one specific docker example)
    • Fix issue with downloading sample assets(currently paths resolve based on the cwd)
    • Add better abstraction to simplify adding new examples with less boilerplate
  • Some examples fail randomly because web socket connection is established too early (probably some sleep would fix the issue)
@wkozyra95 wkozyra95 changed the title examples dir cleanup examples dir refactor + cleanup Jul 1, 2024
@brzep brzep self-assigned this Jul 2, 2024
@brzep brzep linked a pull request Jul 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants