Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small update #270

Closed
wants to merge 1 commit into from
Closed

Small update #270

wants to merge 1 commit into from

Conversation

kksudo
Copy link

@kksudo kksudo commented Apr 25, 2017

Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I proposed an alternative wording. Can you also change the commit title to something more descriptive like:

docker example: document stolon binaries build step

@@ -21,6 +21,8 @@ The `etc/init-spec.json` file provides a minimal default Stolon cluster specific

A convenient `build` target is provided in the Makefile to build all the components' image and generate the needed secrets.

At first - you need run ``` ./build.sh``` in the project root for files generation in ``` /bin``` and others initial.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something like:

To build the image you should first run `./build` in the project root (it'll build the stolon binaries and copy them in the `examples/docker/bin/` directory.

@sgotti
Copy link
Member

sgotti commented May 29, 2018

Closing since old and the docker example was drastically changed.

@sgotti sgotti closed this May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants