[WIP] Add command to restart all underlying pg #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aswin Karthik <[email protected]>
Co-authored-by: Aswin Karthik <[email protected]>
|
@prabhu43 Thanks for the PR, do you need a review or should I wait untile it's not a WIP and tests passes? |
|
@sgotti Please review the implementation and give your feedback. We marked it as WIP to write few more tests. We will fix the failing tests and write few more tests |
sgotti
requested changes
Nov 8, 2018
| @@ -779,10 +781,53 @@ func (p *PostgresKeeper) Start(ctx context.Context) { | |||
|
|
|||
| case <-endUpdateKeeperInfo: | |||
| updateKeeperInfoTimerCh = time.NewTimer(p.sleepInterval).C | |||
| case <-restartPGTimerCh: | |||
| go func() { | |||
| p.restartPostgresIfScheduled(ctx) | |||
There was a problem hiding this comment.
I will prefer to not add a new time and a new function the read clusterdata again, this will also cause some race condition when an user asks to restart postgres while the main loop is acting on it. So I'll do this in the main check.
|
@prabhu43 can we close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
This PR is to restart the underlying postgres instances of all keepers
Reason
Few parameters like
max_connectionsandshared_buffersrequire restart of underlying postgres in each Keeper. We always had to run apg_ctl stop -m fast -Won the node/pod to restart the postgres (keeper only does a reload)Approach
Keeper
schedulePgRestartis set to truepgManagerCLI
stolonctlhas a subcommand calledpgrestartschedulePgRestarttotruefor all keepers (which would trigger a restart of all clusters)Objective
Initially, we wanted to achieve a restart with 0 downtime by promoting an existing slave as a master as present in #88 However, it takes 7 seconds to elect a new master. Simply triggering a fast restart of postgres only cause 1 second downtime.
Please share your comments and feedbacks.