Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oddly non-functioning #49

Open
nodakamakadon opened this issue Oct 3, 2016 · 1 comment
Open

Oddly non-functioning #49

nodakamakadon opened this issue Oct 3, 2016 · 1 comment

Comments

@nodakamakadon
Copy link

nodakamakadon commented Oct 3, 2016

I've had little success getting this to work and it ultimately came down to:

common.py lines 116-120 'details[artist..album..etc] = None' // record nothing for the track
and
ImportList.py lines 231-233 'skip track if details[artist..album..etc] = None' // check for the above nerf

It was an odd alignment amounting in zero functionality, at least that's what I've found. What's the go? I assume I'm missing something but if not, thought it worth a mention ...

@soulfx
Copy link
Owner

soulfx commented Oct 5, 2016

Does ExamplePlaylist.csv import? Double check your csv file against the example playlist to see if it matches the format.

The ExamplePlaylist.csv file has a lot of comments in it and some simple text searches at the beginning. You can ignore those, based on the lines you narrowed in on it looks like you are attempting to import a details track. a details track line should have the following format:

title,artist,album

also, other things to try is to take your playlist you are trying to import and just a few songs before importing everything. there could be a character or formatting issue that is throwing things off.

you should see something like the following when importing the ExamplePlaylist.csv

$ python ImportList.py ExamplePlaylist.csv
gmusic-playlist: 0.160530
gmusicapi: 10.0.0
Reading playlist... done. 51 lines loaded.
Logging into google music...
*****
Login Successful.
Loading personal library... done. 4834 personal tracks loaded.
===============================================================
Searching for songs from: ExamplePlaylist
===============================================================
test comment (and blank track)
test fuzzy artist title search
test fuzzy title artist search
test fuzzy search for song that should return a low match
 - instant karma! we all shine on john lennon {s}{T} #2
   Instant Karma! (We All Shine On) (2010 - Remaster),John Lennon,Power To The People: The Hits
test detailed library search (this song isn't in aa, but it's in my library)
test detailed all access search (the top fuzzy result is incorrect)
this should return a low result
test detailed search which should return song from library if you have it
test album distinction and slight artist mismatch
test slight title mismatch
test low score, mismatched title, and mistmatched artist, and comma in entry
test low score, mismatched title, mismatched artist, mismatched song, and entry comma
 - 1o1,Chris Duarte Groop,Ronp {s}{T}{A} #11
   101,Chris Duarte Group,Romp
test useless info in brackets and duplicate checks
 - 1o1 (Live!) [In Concert] {World Tour},Chris Duarte Groop,Ronp {s}{T}{A}{D} #12
   101,Chris Duarte Group,Romp
test title only search
 - Be Thou My Vision,Dallan Forgaill, {s}{A} #12
   Be Thou My Vision,Selah,Greatest Hymns
test initial unmatched fuzzy with info in brackets
 - stray cats (asdfDoNotMatchMe1234) stray cat strut {s}{D} #13
   Stray Cat Strut,Stray Cats,Greatest Hits

expected results
13/15 tracks imported
2 duplicate tracks

===============================================================
Adding 13 found songs to: ExamplePlaylist
===============================================================
 + ExamplePlaylist - 13/13 songs
===============================================================
   13/15 tracks imported
 ! 0.0% of tracks could not be matched
 - 33.3333333333% of tracks had low match scores
  {T} 3 low matches were due to a song title mismatch
  {A} 3 low matches were due to song artist mismatch
  {D} 2 duplicates were found and skipped
 + 66.6666666667% of tracks had high match scores

top 3 genres: [(u'Pop', 3), (u'Rock', 3), (u'Alternative/Indie', 2)]
top 3 artists: [(u'Chris Duarte Group', 2), (u'Art Of Noise', 2), (u'Stray Cats', 2)]
top 3 years: [(2010, 4), (2013, 2), (2000, 2)]
playlist playback ratio: 2.23076923077

search time: 4.41135811806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants