Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping SQUARE_READER_SDK_REPOSITORY_PASSWORD secret? #229

Open
jessechounard opened this issue Apr 28, 2024 · 0 comments
Open

Keeping SQUARE_READER_SDK_REPOSITORY_PASSWORD secret? #229

jessechounard opened this issue Apr 28, 2024 · 0 comments
Labels
question Further information is requested

Comments

@jessechounard
Copy link

Describe your question

Following the "Getting Started" guide (which worked great, btw!) I've added my square reader sdk repository password to the project level gradle.properties file, and everything works as expected. This is a secret that I should keep safe, right?

If I understand correctly, that data is only used at build time and won't be exposed if someone was to disassemble my binary. But now that I'm ready to commit my files to my project repo, it seems like I should move it out of the gradle.properties file to somewhere else. Unfortunately, when I do so (like loading it from an untracked local.properties file inside build.gradle) I run into problems because the values aren't found by the build.gradle inside node_modules/react-native-square-reader-sdk/android.

Before I spend any more cycles trying to find a workaround, I figure I should ask. Is this something I should be worried about?

Thanks!

@jessechounard jessechounard added the question Further information is requested label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant