Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

gRPC handler errors aren't returned correctly #15

Open
1 of 2 tasks
srerickson opened this issue Jan 11, 2023 · 0 comments
Open
1 of 2 tasks

gRPC handler errors aren't returned correctly #15

srerickson opened this issue Jan 11, 2023 · 0 comments

Comments

@srerickson
Copy link
Owner

srerickson commented Jan 11, 2023

Two separate issues, but I'll track them together:

  • In grpc handlers, I'm returning naked err values on error, but they should be wrapped with grpc error codes. See here: https://connect.build/docs/go/errors
  • If the GetContent() handler returns an error, the client doesn't catch it. The fix is to check the response error after receive is done.
@srerickson srerickson changed the title gRPC errors are returned correctly gRPC handler errors aren't returned correctly Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant