Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokenGenerator.image.tag can ask for images that do not exist #22

Open
mleklund opened this issue May 9, 2024 · 3 comments
Open

tokenGenerator.image.tag can ask for images that do not exist #22

mleklund opened this issue May 9, 2024 · 3 comments
Assignees

Comments

@mleklund
Copy link
Contributor

mleklund commented May 9, 2024

          {{- $v := semver .Capabilities.KubeVersion.Version }}
          image: "{{ .Values.tokenGenerator.image.repository }}:{{ printf "%d.%d.%d" $v.Major $v.Minor $v.Patch }}"
          {{- end }}

It might just be bad luck on my part, but my eks version is v1.27.12-eks-adc7111, and there is no alpine/k8s image that matches. Unfortunately it does not look like they tag without the patch (1.27).

@echozio echozio self-assigned this May 9, 2024
@echozio
Copy link
Contributor

echozio commented May 9, 2024

We attempted to resolve this earlier by using semver to parse it, but I suppose the patch version then ends up being 12-eks-adc7111? Will look into this

@mleklund
Copy link
Contributor Author

mleklund commented May 9, 2024

No it gets 1.27.12 just fine, but alpine/k8s:1.27.12 does not exist. 1.27.13 and 1.27.11 do exist. There may not be a great fix for this. Probably related to alpine-docker/k8s#75

@echozio
Copy link
Contributor

echozio commented May 9, 2024

Ah, sorry, skimmed it a little too quick. Probably not something we should work around in this chart, then. The image only uses kubectl to get/create a secret, so the best workaround will be just setting tokenGenerator.image.tag to something near that exists.

Thanks for bringing light to this. If this is going to be a common occurrence we may look at switching it out for something else, but well maintained utility images like this seem sort of few and far between.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants