Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove null for collections #10

Open
silasjoisten opened this issue Jan 17, 2025 · 0 comments
Open

Remove null for collections #10

silasjoisten opened this issue Jan 17, 2025 · 0 comments

Comments

@silasjoisten
Copy link
Collaborator

If a collection can be empty, then we don't need to allow null and don't need to use it as a default value in StoriesRequest, just use:

- public ?RelationCollection $withRelations = null,
+ public RelationCollection $withRelations = New RelationCollection(),

this would also simplify the check in StoriesRequest::toArray() then

Originally posted by @OskarStark in #8 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@silasjoisten