Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: BrandImage resizes itself in dark theme when resizing sidebar #28192

Open
mayabuserde opened this issue Jun 10, 2024 · 7 comments · May be fixed by #28812
Open

[Bug]: BrandImage resizes itself in dark theme when resizing sidebar #28192

mayabuserde opened this issue Jun 10, 2024 · 7 comments · May be fixed by #28812

Comments

@mayabuserde
Copy link

Describe the bug

When switching to the Storybook dark theme, the BrandImage resizes itself when changing the width of the sidebar. The same problem seems to have been addressed for the light theme in this issue: #24702.

Depending on the width of the sidebar, the logos might be different sizes when switching between themes.

I think the dark theme should behave like the light theme.

Screen.Recording.2024-06-10.at.3.04.54.PM.mov

Reproduction link

N/A

Reproduction steps

No response

System

Storybook Environment Info:

  System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Pro
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.7.0 - ~/.nvm/versions/node/v18.7.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.7.0/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v18.7.0/bin/npm
    pnpm: 8.3.1 - ~/.nvm/versions/node/v18.7.0/bin/pnpm <----- active
  Browsers:
    Chrome: 125.0.6422.142
    Edge: 125.0.2535.92
    Safari: 17.5
  npmPackages:
    @storybook/addon-a11y: 8.0.9 => 8.0.9 
    @storybook/addon-actions: 8.0.9 => 8.0.9 
    @storybook/addon-essentials: 8.0.9 => 8.0.9 
    @storybook/blocks: 8.0.9 => 8.0.9 
    @storybook/theming: 8.0.9 => 8.0.9 
    @storybook/web-components: 8.0.9 => 8.0.9 
    @storybook/web-components-vite: 8.0.9 => 8.0.9 
    chromatic: 5.8.3 => 5.8.3 
    storybook: 8.0.9 => 8.0.9 
    storybook-dark-mode: 4.0.1 => 4.0.1

Additional context

No response

@mugunthankrishnan
Copy link

mugunthankrishnan commented Jul 18, 2024

Hello @vanessayuenn and @mayabuserde,
I'm new to open source contribution and would like to get started. Can you please give me any tips and processes that I need to follow to contribute to this issue?
Thanks.

@logee48
Copy link

logee48 commented Jul 19, 2024

Hey,
I can fix it, Assign it to me.
Thank you

@ArchitGajjar
Copy link

Hi @mayabuserde - thank you for sharing video and details. I would like to contribute into this project, can you please assign this to me ? Thank you so much! :)

@mayabuserde
Copy link
Author

Hi @vanessayuenn, can you help with assigning the issue to someone or provide some guidance on how to start working on it?
Thank you!

@hakshu25 hakshu25 linked a pull request Aug 5, 2024 that will close this issue
8 tasks
@ShreySinha02
Copy link

@mayabuserde hii is this issue fixed because i am tried reproducing it but it is working normally for me
Screencast from 04-09-24 08:13:56 PM IST.webm

@mhmdjaw
Copy link

mhmdjaw commented Sep 7, 2024

@ShreySinha02 Nope still happening.. it only affects the width of the logo. In your case the width is fixed that's why it doesn't resize.

@ShreySinha02
Copy link

hii @mayabuserde please look #29129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants