Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Double stringification of conditions column values on the admin_permissions table. #39

Open
ConradP opened this issue Aug 31, 2022 · 2 comments · Fixed by #40
Open

Double stringification of conditions column values on the admin_permissions table. #39

ConradP opened this issue Aug 31, 2022 · 2 comments · Fixed by #40
Labels
issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: v3-SQL to v4-SQL status: confirmed Confirmed by a Strapi Team member or multiple community members

Comments

@ConradP
Copy link
Contributor

ConradP commented Aug 31, 2022

Bug report

Required System information

  • Node.js version: 14.20.0
  • NPM version: 6.14.17
  • Source Strapi version: 3.6.8
  • Target Strapi version: 4.3.6
  • Source Database: sqlite or mysql (verified on both)
  • Target Database: sqlite or mysql (verified on both)
  • Operating system: Ubuntu 22.04 LTS
  • Which script are you running: v3-sql-v4-sql

Describe the bug

The conditions values in the admin_permissions tables are improperly formatted after running the migration script, this causes application crashes for admin users assigned to any role created pre-migration besides the super admin.

Steps to reproduce the behavior

  • create a quickstart v3 project
  • add an admin user to the project, assign them the editor or author role
  • create a quickstart v4 project
  • migrate the database from v3 to v4 using the migration script configured for the sqlite databases
  • start the v4 application
  • log in to the dashboard as the created user
  • dashboard will crash and 500 errors observed on the server side

Expected behavior

The dashboard does not crash and the server does not error.

@ConradP
Copy link
Contributor Author

ConradP commented Aug 31, 2022

I have created #40 to resolve this issue, it has been verified for both SQLite and MySQL/MariaDB databases. I have not tested it on a PostgreSQL database

@derrickmehaffy
Copy link
Member

Reopening this as I had to revert the PR merge of #40 as other users were reporting problems in #19

@derrickmehaffy derrickmehaffy reopened this Sep 6, 2022
@derrickmehaffy derrickmehaffy added issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: v3-SQL to v4-SQL status: confirmed Confirmed by a Strapi Team member or multiple community members labels Sep 6, 2022
@derrickmehaffy derrickmehaffy moved this to To be reviewed in v3 to v4 Migration Project Sep 6, 2022
@derrickmehaffy derrickmehaffy moved this from To be reviewed to Reviewed in v3 to v4 Migration Project Sep 6, 2022
@maccomaccomaccomacco maccomaccomaccomacco moved this from Reviewed to Fixed/Shipped in v3 to v4 Migration Project Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: v3-SQL to v4-SQL status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants