-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display object note above quest and overlay answers #5889
Conversation
If it exists, the `note` tag for an object is shown in the QuestHint.
Adding Bus Stop Name in the mix also.
This should be implemented generally for any quest type form and overlay form and should not use the Regarding the wording, I think it should be made clear that this is a note from another user. Maybe something like Another mapper wrote: "bla bla bla" |
This comment was marked as outdated.
This comment was marked as outdated.
I absolutely agree, it would be most useful that |
Yes |
I like this implementation, thank you for making the proposal Kai! The font looks small, which should make the maximum note length at 255 characters not be a problem. My phone screen is a bit less tall than yours (still too tall, I can't reach notifications one-handed, but alas) so I checked the screenshots on there and the text is easily readable at arm's length. Adding quotes and perhaps italics as mentioned above, to make it clear that it's user-supplied text, sound good to me. I was missing something there as well, but thought that having a vertical bar on the left side for a blockquote, like GitHub's quote areas, would take more vertical space than necessary. |
How do we like this? The note is now part of the I would assume that people have seen the |
I like it! Or maybe "Another mapper noted:" is even better? Maybe put the user's text in quotation marks or like the GitHub quote areas as suggested above? Also, seeing your screenshot, I guess it often happens that the note is completely unrelated to the question. How can we avoid confusing the user here? UI-wise, I do wonder whether it would be better to display it in an extra bubble just like in @mnalis mockup in the issue ticket. Semantically, it would make sense - it is not part of the question but a note by a third party. |
Yeah, I think notes should also be shown in the overlays (in all overlays). |
What would be very useful (and I don't know if that is the case currently), is if the text from that Also, if there are http/https links, could they be made clickable? For example, when showing/solving OSM Note quest, both are possible, and both have been proven very useful in practice! So perhaps code could be borrowed from there? |
Removed Nested Scroll View (streetcomplete#5889 (comment)) and TextStyles (streetcomplete#5889 (comment)), made `note` text selectabled (copyable) as web links clickable (as per streetcomplete#5889 (comment)) and
Both done in fa183c2 |
Awesome! |
app/src/main/java/de/westnordost/streetcomplete/quests/AbstractQuestForm.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/AbstractOsmQuestForm.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/AbstractQuestForm.kt
Outdated
Show resolved
Hide resolved
Simplifications
@westnordost when transferring this to master, feel free to use squash and merge, I've got the checkin history in my fork but that doesn't need to be in master imho. |
@lgommans As you brought this up, would you like to make a comment on the looks of it? |
To me it seems that it would be more consistent to have the house number / location label above the note. You wrote you liked it (that?) thus far. Why do you think it is better that way? |
|
I'd put this in the next major version (which will come out soon-ish anyway, v59 only took that much time because of MapLibre issues). |
Sounds good to me :) |
I saw the email notifications come in today but only just now had a chance to catch up with the thread. Thanks for inviting my feedback :) It looks great! Also the extra copying and link-parsing features, I did not even expect it to be so featureful! 🚀 The only thing I was just wondering about while eyeing the screenshots is the phrasing of "Another person noted". With notes being another OSM feature and also used in StreetComplete, that phrasing might be confusing for those who aren't used to looking at tags (also considering iD's habit of hiding those). One might wonder "who wrote this, why, how can I comment on it? Can I modify or remove it if it's outdated?" Some options:
What do you think? |
None of the suggestions I think would make it less confusing, but more. "Noted" is used here in the sense of "remarked". (But overall I personally find it better to use "noted" because it hints at - for advanced users who know the tag - that this might indeed be the |
Okay, then let's just leave it as it is :) Thanks again for everyone's work on it! |
Resolves #5794.
Removed outdated screenshots ans behaviour, see #5889 (comment)
Marking this as a draft, looking for feedback.