Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitter when opening the quest «What is width of opening here?» #5813

Open
deevroman opened this issue Aug 19, 2024 · 6 comments
Open

Jitter when opening the quest «What is width of opening here?» #5813

deevroman opened this issue Aug 19, 2024 · 6 comments
Labels
help wanted help by contributors is appreciated; might be a good first contribution for first-timers

Comments

@deevroman
Copy link

How to Reproduce
Find the quest "What is width of opening here?" on the map and open it

When zooming in, the animation is ragged. When opening other point quests, the map zooms in smoothly

Screen_Recording_20240819_140024_StreetComplete.mp4

https://www.openstreetmap.org/node/3359945255

Versions affected
v59.0-alpha1
Android 14 OneUI 6.1
Samsung A52

p.s. Congratulations on the long-awaited migration to MapLibre!

@deevroman deevroman added the bug label Aug 19, 2024
@westnordost
Copy link
Member

Yes, this has existed since very long, i.e. since the measure quests were first created. I think the same happens for the opening hours quest, no? It's definitely because of the form, not of MapLibre. I'll have a short look at this...

@westnordost westnordost self-assigned this Aug 19, 2024
@deevroman
Copy link
Author

I think the same happens for the opening hours quest

No, for this quest, the zooming is smooth. The road surface quest also has a similar lag, but there it can be explained by a more complex geometry that needs to be displayed. Perhaps this is also due to the more complex form of the response with pictures, I don't know :/

@westnordost
Copy link
Member

By the way, any quest form cannot appear (and must wait on the UI thread) until the features dictionary is loaded. The loading is done in the background on each start, so if you immediately open a quest after start, it will be jittery (because the features dictionary must first finish loading).

But I can confirm that this form also jitters after it has been loaded. After some tests, I have been unable to find where this is coming from, however.

@westnordost westnordost added the help wanted help by contributors is appreciated; might be a good first contribution for first-timers label Aug 19, 2024
@westnordost westnordost removed their assignment Aug 19, 2024
@westnordost westnordost removed the bug label Aug 19, 2024
@lgommans
Copy link

Interesting, I didn't know there was supposed to be an animation at all. Perhaps I enabled some OS setting to reduce animations since they're usually just artificial delays in workflows as well as battery-eating compared to just rendering the intended view once.

Come to think of it, why does it zoom? I got so used to it that I forgot it bothered me. Can we disable it altogether? If I wanted to have a different zoom level, I'd use this little feature of streetcomplete's called zooming :p

Maybe we could do a quick show of 👍/👎 on this comment to indicate whether the zoom also bothers you? So that 👍 is in favor of keeping the user's chosen zoom level. An 👀 could be used for "I've seen the poll but don't care whether it zooms or not". Of course, anything other than an overwhelming majority would mean it a setting is something to consider; this is just about what you would set that setting to if it existed.

@mnalis
Copy link
Member

mnalis commented Aug 24, 2024

anything other than an overwhelming majority would mean it a setting is something to consider

@lgommans Note however that StreetComplete is very reluctant to adding new user preferences. (if there is enough interest to add such option, it might perhaps be an option for SCEE, though)

@westnordost
Copy link
Member

westnordost commented Aug 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted help by contributors is appreciated; might be a good first contribution for first-timers
Projects
None yet
Development

No branches or pull requests

4 participants