-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurveing: Add double check when values change #5883
Comments
It does not display currently tagged info |
I agree, it should do this beforehand. |
I can't find original post now, but AFAIR it was explained that it is intentional behaviour that bicycle parking count is not shown beforehand. Reasoning was along the lines that for the resurvey to make any sense, the user must count the parking spots again. If the number was shown beforehand, that is very high likelyhood that many users (out of laziness & trusting the static universe model) would just confirm what was already there instead of counting, thus rendering resurvey quest worthless at best (or even more, actively problematic, as it would update old number with new Thus, the first two suggestions should not be implemented, but something along the lines of a third one might:
As suggested, it might still be problematic (users could just enter But a variation that verifies old value to new one, and if they differ asks (without mentioning the old number) "It seems that the number of parking spaces here has changed, please double check your count. I DOUBLECHECKED, CONFIRM NEW COUNT | OOPS, I MISCOUNTED, LET ME REVISE THE NUMBER" |
I think the default assumption that our users are lazy is odd. I mean how long does it count to 4 or to 20? That's a not a task where I think someone would skip this step. This however may very well be a concern on parking lots for cars, where the number is say 254 or something like that. In this case it's fine IMHO to show the number and ask for confirmation. |
From what I remember it was on pile of "big implementation effort given benefits, write PR if you want". |
TL;DR: see double-blind scientific methodology for reasoning why showing data first is bad idea for accuracy, and for counting task it does not gain us any convenience (as opposed to say
I was trying to be short and simple (given my tendency to get overly long), but the whole known psychological issue is much more complex, and (beside "plain laziness", which is in itself probably quite complex) is resulting from observer bias, confirmation bias, and other factors; which is why in science such blinding is considered essential in order not to get biased/skewed/wrong data (recent standards requiring at least double blinding, and sometimes triple blinding) Anyway, long story short, it is known and proven psychological deficiency of human brain. (it is probably intentional evolutionary tendency though: over-optimizing in order to save time and energy)
Similar issues have been discussed previously (i.e. ideas for applying same "building type" to answer to multiple buildings is problematic not only for UI and implementation standpoint, but it also would invite not checking each building type but answering "surely all of them must be Thus, verifying the data matching only after it has already been counted (thus, without bias!) and entered is significantly better idea which produces more quality data for same amount of work. e.g. "It seems that the number of parking spaces here has changed, please double check your count. I DOUBLECHECKED, CONFIRM NEW COUNT | OOPS, I MISCOUNTED, LET ME REVISE THE NUMBER" |
Thanks for the context. I was thinking about why some users make this mistake. When we assume the users know what they are doing (AKA how to count capacity ec) and are careful with their mapping, which I think we can, that leaves mistakes due to not understanding which object they are mapping or how the objects relate. In Berlin, we have a very high level of details on the sidewalks and roads which means I needs to orient myself very well to match the digital map with what I see in the real word. SC map style is not ideal for this kind of situation (for good or at least understandable reasons). There are a few factors that make the bicycle parking quest different from others…
There are a few open tickets that would help here, like #56 and more details on the map which might be possible once the map design becomes easier to modify with maplibre. For now, the easiest way to make it easier for users to understand which objects they are changing to see the data that is already there. Be it before or after they did their re-survey… |
I expect it depends on ratio of wrong answers when capacity is not shown and how often people are incorrectly swayed by shown value. I expect that it differs in various cases. Do you have links to this research? Has it been replicated? (Any not replicated psychology research should be considered as not worth much if anything, see replication crisis)
Maybe a tiny bit as often you will not need keyboard |
Do you have example mistakes? I seen one user who counted U-shaped stands interest of counting 2 capacity for each (and there was space on both sides), despite the hint |
I linked the most recent example in my initial post which is the area I linked in the comment you quoted. Other similar cases are already solved and I will not have the time to dig them up again. |
Another example of resurveying mistakes (it was my fault in case): https://osmcha.org/changesets/157167301?aoi=69f2fba4-6afb-4c5f-a89a-2a6538c9432a In this case, I was resurveying (without knowing that it was a resurvey, I assumed I was surveying it the first time) a recycling container. We have large containers for "packaging waste" ("Verpackungsmüll"), which includes plastic packing and metal cans. However, since I always think of these containers as "plastic waste containers", I forgot to add metal cans. As a result, my changeset actually only removed cans. If SC had asked me "Are you sure that you removed metal cans?", I would have said "Oh no, my mistake, I forgot about them, thanks for double-checking". I don't know if that's a common case, just wanted to add some user feedback :) |
@fxedel yeah, I think we should at least show that the user is changing something, vs adding new data. And what the user is changing exactly, to catch those mistakes. However in your case you also wouldn't have this mistake if that data would have been presented and you've asked to confirm it, this by the way is the default case in OSM: The editing user is presented with the existing data, and he/she can choose to make changes. Not sure why we should differ from this in SC, still. |
Actually, I think we should review for which quests the question is asked again. What changed since their implementation?
For the case of bicycle parking capacity, I do think that the bicycle parking capacity should probably not be asked again, because realistically, the parking capacity doesn't change for a bicycle parking. I've never seen a bicycle parking being just extended (or reduced). Rather, instead, if the bicycle parking is redesigned, it may end up being at a (slightly) different position, have a different type (e.g. racks -> double-decker racks), etc., or be gone (at that location) altogether. Other quests should be reviewed, too. But for most, nothing should change. E.g. roads usually can have their surface renewed (i.e. -> surface, smoothness quests) without the whole road vanishing and reappearing in a slightly different form or location :-) |
In my city it is normal for bicycle parkings to be expanded or run over, but maybe it is not true more generally |
What do you mean, "run over"? |
that part of bicycle parking was destroyed by a car that run over it some also got lost after road was renovated |
Same here, a hardware store just doubled the parking spots for bikes while also adding two outlets for charging. 3 years ago there were zero parking spots for bikes. |
Hm okay, I see. Well, I will review the other re-check quests anyway. As per the original feature request, I would close this as will not fix. Whatever was tagged before should not matter when the user decides what value he specifies, after all, he is there right now and sees with his own eyes the current situation. If any quest is worded in a way that it is confusing or answer options are not clear so that it leads to systematic incorrect answers, then the quest should be enhanced to not be confusing or ambiguous instead of burdening the user to doubt and/or compare his answer with a previous answer. Such confirmation dialogs are usually mostly just annoying for users rather than helpful to achieve a better data quality. Also, both either implementing such a confirmation dialog or in some way or another showing the previously tagged value would need to be implemented for each form individually which would make this also quite time consuming to do and maintain, never mind the possible inconsistency when such a confirmation dialog is shown for one quest, but not another. |
Though for example for recycling quest I have faint plan to implement ability to show what is tagged with option to quickly confirm it. No promises that I will implement it soon, I will first finish some of already started projects. |
Reviewed re-check quests. Just two remain where I am considering to remove the re-check:
|
…& less often (done in frame of #5883 although not that related) because if it changes, it more likely happens at the same time. Also, with separate footway mapping, there are **many** kerbs.
Well, on the flipside it still improves accuracy of the data, if we check it every 6 years or so. So if people rely on them, it's good to make sure that they are accurate from time to time. I would vote for rechecking them, much stuff can be change in 6 years. |
Yeah, I see not much problem with leaving rechecking them, especially considering that they are rare enough not to present noticeable spam; and there are some uses for them. While I agree that is somewhat unlikely that they degrade (e.g. camp offering drinking water suddenly stopping to do so), situation might occasionally improve (e.g. alpine hut that didn't have power might get solar panels installed, especially with all "renewable and energy independent" trends in EU and elsewhere. Or a smaller camp without showers might grow if there is enough business at the location and get showers outbuilding) Additionally, those quests work as alternate "existence check" quest, so if recheck for (some of) those quests were to be removed, at least check for camp / alpine hut should be added to existence quest. (especially camps IME are known to close from time to time - more often than I'd like, in fact) |
This is a mute argument, my point is, that because we have the existence check, we don't need other quests to confirm their existence. |
I know, that is why it was prefixed with "Additionally". The main argument for retaining status quo was above it:
That being said, if you think it would be noticeably better if recheck in those quests was replaced by moving it to existence quest, I won't throw a tantrum 😃, even if I do think currently solution might be slightly better |
Oh, you are right, camps are actually not checked in the check existence quest. Nevermind then. Anyway, closing this as will not fix. |
Not followed the discussion in detail but
I know a shop which dropped selling second hand bikes. |
Now as you're saying this indeed, I know a car dealer which also offered bicycle repairs and the service that you can give them your old bike if you buy a new one and if they sell it you'll get this as a discount later on. But they stopped doing both of that, only offering new bike sales nowadays. |
I really like the re-surveing feature that SC introduced and spearheads. But I wonder if things can be done to reduce miss-tagging in some use cases.
Use case
I notice a few times that the bicycle stands capacity resurveing quest introduces wrong data.
An example is
https://osmcha.org/changesets/156286947/?aoi=3ee95214-1a8e-4a7e-8546-5c9c0ac2b006
But I noticed other times before that.
In my experience this quest is more likely to be miss-tagged during resurvey than others, but I cannot pinpoint this or think that it is relevant.
Proposed Solution
Last time I checked SC does not show the current data anywhere during the re-surveing.
My thinking is, that this should change in order to trigger a "who is wrong, me or the prev. mapper?" though in the current user, which will certainly improve the accuracy of the data.
I think this can be added in multiple ways which all have the dis/advantags. They are all OK IMO.
Personally I like the last case the most, because it does not change the current flow.
The text was updated successfully, but these errors were encountered: